Repository navigation
docs(material/tabs): clarify when background and foreground tokens apply - #33988
lxminarayn wants to merge 1 commit into
Conversation
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
We intentionally didn't support this. It's a legacy feature that is only in M2, not M3.
|
Thanks for clarifying & quick review! That makes sense given backgroundColor is M2-only and deprecated. The confusion in #30186 seems to come from tabs-overrides accepting background-color and foreground-color in M3 and the styling docs listing them, even though they have no effect there. Would you be open to a small change that documents these two tokens as only applying with the M2 backgroundColor input, or excludes them from the M3 overrides? If not, I'm happy to close this. |
|
Sure, we can change it to a docs PR. |
Notes that the `background-color` and `foreground-color` tokens only take effect when the `backgroundColor` input is set, which is supported in M2 themes only, and points to the tokens that customize the label and indicator colors in M3 themes. Fixes angular#30186.
1caf3ef to
4bef01b
Compare
lxminarayn
changed the title
|
@crisbeto , I've replaced the change with a docs update to the tabs overview. |
|
@crisbeto / @andrewseguin did you get a chance to check on this? |
Documents that the
background-colorandforeground-colortokens oftabs-overridesonlytake effect together with the
backgroundColorinput, which is supported in M2 themes only,and points to the tokens that customize the label and indicator colors in M3 themes.
Fixes #30186