Skip to content

refactor(material/sort): inject AriaDescriber as required #33899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MeAkib wants to merge 1 commit into from
Closed

refactor(material/sort): inject AriaDescriber as required #33899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/material/sort/sort-header.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class MatSortHeader implements MatSortable, OnDestroy, OnInit, AfterViewI
private _changeDetectorRef = inject(ChangeDetectorRef);
private _focusMonitor = inject(FocusMonitor);
private _elementRef = inject<ElementRef<HTMLElement>>(ElementRef);
private _ariaDescriber = inject(AriaDescriber, {optional: true});

@crisbeto crisbeto Sep 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a reason we didn't do this during the inject migration was that some apps were stubbing this out somehow in tests.

@MeAkib MeAkib Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context, that makes sense. I'll close this.

private _ariaDescriber = inject(AriaDescriber);
private _renderChanges: Subscription | undefined;
protected _animationsDisabled = _animationsDisabled();

Expand Down Expand Up @@ -165,7 +165,7 @@ export class MatSortHeader implements MatSortable, OnDestroy, OnInit, AfterViewI
this._renderChanges?.unsubscribe();

if (this._sortButton) {
this._ariaDescriber?.removeDescription(this._sortButton, this._sortActionDescription);
this._ariaDescriber.removeDescription(this._sortButton, this._sortActionDescription);
}
}

Expand Down Expand Up @@ -226,9 +226,8 @@ export class MatSortHeader implements MatSortable, OnDestroy, OnInit, AfterViewI
// nothing to update in the DOM.
if (this._sortButton) {
// removeDescription will no-op if there is no existing message.
// TODO(jelbourn): remove optional chaining when AriaDescriber is required.
this._ariaDescriber?.removeDescription(this._sortButton, this._sortActionDescription);
this._ariaDescriber?.describe(this._sortButton, newDescription);
this._ariaDescriber.removeDescription(this._sortButton, this._sortActionDescription);
this._ariaDescriber.describe(this._sortButton, newDescription);
}

this._sortActionDescription = newDescription;
Expand Down
Loading