Conversation
`MatSortHeader` was injecting `AriaDescriber` as optional and guarding every call with optional chaining. `AriaDescriber` is always available since it's automatically provided, and `MatTooltip` and `MatBadge` already inject it as required, so we can drop the optional flag and the null checks.
crisbeto
reviewed
Sep 30, 2026
| private _changeDetectorRef = inject(ChangeDetectorRef); | ||
| private _focusMonitor = inject(FocusMonitor); | ||
| private _elementRef = inject<ElementRef<HTMLElement>>(ElementRef); | ||
| private _ariaDescriber = inject(AriaDescriber, {optional: true}); |
Member
There was a problem hiding this comment.
I think a reason we didn't do this during the inject migration was that some apps were stubbing this out somehow in tests.
Contributor
Author
There was a problem hiding this comment.
Thanks for the context, that makes sense. I'll close this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MatSortHeaderwas injectingAriaDescriberas optional and guarding every call with optional chaining.AriaDescriberis always available since it's automatically provided, andMatTooltipandMatBadgealready inject it as required, so we can drop the optional flag and the null checks.