One failed search batch no longer strands the albums behind it - #7
Merged
Conversation
Searches go out in hundreds and a failing batch raised immediately, so a 250-album chart could lose its last fifty to one timed-out request, with nothing said. Every batch is attempted; the summary reports what missed. Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
alperien
added a commit
that referenced
this pull request
Jul 28, 2026
Version bump and changelog. No code changes; everything here landed in #4, #5, #6 and #7. Four fixes since 0.1.0, led by the review screen redrawing about 17,000 times a second while it waited for a keypress. Also: a skip or re-pick ignored on a row that also matched, one failed search request stranding the albums behind it, and basic-auth credentials appearing in error messages. Adds the u undo key and an idle-albums note when --search is off. The --search round trip between #4 and #6 is deliberately absent from the changelog: 0.1.0 already searched correctly, and nothing shipped in between, so there is no user-visible bug to report. The dead searchForNewAlbum flag's removal is recorded under Changed. Co-Authored-By: Claude <noreply@anthropic.com>
alperien
added a commit
that referenced
this pull request
Jul 28, 2026
Searches are sent in batches of a hundred and a failing batch raised out of search_albums immediately, so a 250-album chart could lose its last fifty to one timed-out request, reported only as a single line that did not say how many albums it cost. Every batch is attempted now. search_albums returns (queued, errors) and the push reports how many albums went unsearched and why. Ids that came back None are dropped before batching. The last idea worth taking from fix/robustness-audit. 142 passing.
alperien
added a commit
that referenced
this pull request
Jul 28, 2026
Version bump and changelog. No code changes; everything here landed in #4, #5, #6 and #7. Four fixes since 0.1.0, led by the review screen redrawing about 17,000 times a second while it waited for a keypress. Also: a skip or re-pick ignored on a row that also matched, one failed search request stranding the albums behind it, and basic-auth credentials appearing in error messages. Adds the u undo key and an idle-albums note when --search is off. The --search round trip between #4 and #6 is deliberately absent from the changelog: 0.1.0 already searched correctly, and nothing shipped in between, so there is no user-visible bug to report. The dead searchForNewAlbum flag's removal is recorded under Changed.
alperien
added a commit
that referenced
this pull request
Jul 31, 2026
Searches are sent in batches of a hundred and a failing batch raised out of search_albums immediately, so a 250-album chart could lose its last fifty to one timed-out request, reported only as a single line that did not say how many albums it cost. Every batch is attempted now. search_albums returns (queued, errors) and the push reports how many albums went unsearched and why. Ids that came back None are dropped before batching. The last idea worth taking from fix/robustness-audit. 142 passing.
alperien
added a commit
that referenced
this pull request
Jul 31, 2026
Version bump and changelog. No code changes; everything here landed in #4, #5, #6 and #7. Four fixes since 0.1.0, led by the review screen redrawing about 17,000 times a second while it waited for a keypress. Also: a skip or re-pick ignored on a row that also matched, one failed search request stranding the albums behind it, and basic-auth credentials appearing in error messages. Adds the u undo key and an idle-albums note when --search is off. The --search round trip between #4 and #6 is deliberately absent from the changelog: 0.1.0 already searched correctly, and nothing shipped in between, so there is no user-visible bug to report. The dead searchForNewAlbum flag's removal is recorded under Changed.
alperien
added a commit
that referenced
this pull request
Jul 31, 2026
Searches are sent in batches of a hundred and a failing batch raised out of search_albums immediately, so a 250-album chart could lose its last fifty to one timed-out request, reported only as a single line that did not say how many albums it cost. Every batch is attempted now. search_albums returns (queued, errors) and the push reports how many albums went unsearched and why. Ids that came back None are dropped before batching. The last of the hardening fixes. 142 passing.
alperien
added a commit
that referenced
this pull request
Jul 31, 2026
Version bump and changelog. No code changes; everything here landed in #4, #5, #6 and #7. Four fixes since 0.1.0, led by the review screen redrawing about 17,000 times a second while it waited for a keypress. Also: a skip or re-pick ignored on a row that also matched, one failed search request stranding the albums behind it, and basic-auth credentials appearing in error messages. Adds the u undo key and an idle-albums note when --search is off. The --search round trip between #4 and #6 is deliberately absent from the changelog: 0.1.0 already searched correctly, and nothing shipped in between, so there is no user-visible bug to report. The dead searchForNewAlbum flag's removal is recorded under Changed.
alperien
added a commit
that referenced
this pull request
Jul 31, 2026
Searches are sent in batches of a hundred and a failing batch raised out of search_albums immediately, so a 250-album chart could lose its last fifty to one timed-out request, reported only as a single line that did not say how many albums it cost. Every batch is attempted now. search_albums returns (queued, errors) and the push reports how many albums went unsearched and why. Ids that came back None are dropped before batching. The last of the hardening fixes. 142 passing.
alperien
added a commit
that referenced
this pull request
Jul 31, 2026
Version bump and changelog. No code changes; everything here landed in #4, #5, #6 and #7. Four fixes since 0.1.0, led by the review screen redrawing about 17,000 times a second while it waited for a keypress. Also: a skip or re-pick ignored on a row that also matched, one failed search request stranding the albums behind it, and basic-auth credentials appearing in error messages. Adds the u undo key and an idle-albums note when --search is off. The --search round trip between #4 and #6 is deliberately absent from the changelog: 0.1.0 already searched correctly, and nothing shipped in between, so there is no user-visible bug to report. The dead searchForNewAlbum flag's removal is recorded under Changed.
alperien
added a commit
that referenced
this pull request
Jul 31, 2026
Searches are sent in batches of a hundred and a failing batch raised out of search_albums immediately, so a 250-album chart could lose its last fifty to one timed-out request, reported only as a single line that did not say how many albums it cost. Every batch is attempted now. search_albums returns (queued, errors) and the push reports how many albums went unsearched and why. Ids that came back None are dropped before batching. The last of the hardening fixes. 142 passing.
alperien
added a commit
that referenced
this pull request
Jul 31, 2026
Version bump and changelog. No code changes; everything here landed in #4, #5, #6 and #7. Four fixes since 0.1.0, led by the review screen redrawing about 17,000 times a second while it waited for a keypress. Also: a skip or re-pick ignored on a row that also matched, one failed search request stranding the albums behind it, and basic-auth credentials appearing in error messages. Adds the u undo key and an idle-albums note when --search is off. The --search round trip between #4 and #6 is deliberately absent from the changelog: 0.1.0 already searched correctly, and nothing shipped in between, so there is no user-visible bug to report. The dead searchForNewAlbum flag's removal is recorded under Changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last idea worth taking from
fix/robustness-audit.Searches go out in batches of a hundred, and a batch that failed raised straight out of
search_albums. On a 250-album chart, one timed-out request in the middle left the last fifty albums unsearched — and the caller printed a singlesearch request failedline that never said how many albums it had cost.Reproduced on current main: with the second of three batches failing, the third is never attempted.
Change
Every batch is attempted.
search_albumsreturns(queued, errors), and the push reports how many albums went unsearched and why, so a partial failure is visible and fixable by rerunning with--search.Ids that came back
Noneare dropped before batching, so a Lidarr that answers an add without a body can't put a null in the command payload.Verification
ruffcleanuv build+twine check --strictpassThis closes out
fix/robustness-auditEverything in that branch is now either on main or deliberately declined:
searchForNewAlbumunreliableUnreachableretry semanticsSearchUnavailableukeysha1(artist+title)--no-searchAfter this, that branch and the other four stale ones can be deleted.