Fix em-dash prose punctuation across messages and docs - #13
Conversation
…gelog Replace prose em dashes with semicolons, colons, commas, or parentheses in error messages, docstrings, code comments, test comments, and CHANGELOG entries. The em dash stays where it is data or chrome: the artist-title separator the TUI prints, the review screen header, the year-range display, and quoted examples of those strings. 142 tests pass and ruff is clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe pull request standardizes punctuation and wording across changelog entries, runtime messages, docstrings, comments, and test descriptions. No executable logic, public declarations, assertions, or control flow changed. ChangesText formatting updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 20: Update the changelog wording from “afterwards” to “afterward” in the
affected sentence, preserving the rest of the text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 82ffb0d9-caaf-458d-8218-04244b163d87
📒 Files selected for processing (13)
CHANGELOG.mdchartarr/__init__.pychartarr/cli.pychartarr/demo.pychartarr/lidarr.pychartarr/matcher.pychartarr/review.pychartarr/screen.pytests/test_cli.pytests/test_lidarr.pytests/test_matcher.pytests/test_review.pytests/test_screen.py
| - **The review screen pinned a CPU core while it waited for you.** The | ||
| progress screens poll for a keypress so they can notice `q` mid-run, | ||
| and that non-blocking mode stayed on the window afterwards — | ||
| and that non-blocking mode stayed on the window afterwards: |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use “afterward” for American English.
Change “afterwards” to “afterward” to match the project’s American-English wording convention.
🧰 Tools
🪛 LanguageTool
[locale-violation] ~20-~20: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ... non-blocking mode stayed on the window afterwards: curses.wrapper does not reset it b...
(AFTERWARDS_US)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` at line 20, Update the changelog wording from “afterwards” to
“afterward” in the affected sentence, preserving the rest of the text.
Source: Linters/SAST tools
The same pass that went over agent-swarm and guavabread, guided by blader/humanizer. chartarr's docs and interaction text were already plain and specific, so this pass is almost entirely punctuation: the em dash used as prose punctuation, which is the most reliable AI tell and the one thing the earlier README rewrites did not sweep.
What changed, 13 files:
What deliberately keeps its em dashes:
No LLM prompts exist in this repo. The interaction surface (help text, error messages, the setup wizard) already does what a good prompt does: it names the cause and the fix in one line. Nothing there needed more than punctuation.
Verification: pytest 142/142, ruff clean. The scanner reports zero hard hits outside the kept separators.
🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
User Experience
Tests