Unify pipeline domain checks on the profile detector#180
Merged
Jiaaqiliu merged 1 commit intoaiming-lab:mainfrom Mar 30, 2026
Merged
Unify pipeline domain checks on the profile detector#180Jiaaqiliu merged 1 commit intoaiming-lab:mainfrom
Jiaaqiliu merged 1 commit intoaiming-lab:mainfrom
Conversation
Jiaaqiliu
added a commit
that referenced
this pull request
Mar 30, 2026
…cation - Remove stale _DOMAIN_KEYWORDS import from executor.py (symbol removed by PR #180) - Fix test_paper_draft_blocked_with_no_metrics: monkeypatch _detect_domain to return empirical domain so the no-metrics block triggers correctly with the new detector
Jiaaqiliu
added a commit
that referenced
this pull request
Mar 30, 2026
- Remove stale _DOMAIN_KEYWORDS import from executor.py (PR #180 removed it) - Fix test_paper_draft_blocked_with_no_metrics for new domain detector - Replace Cyrillic characters with ASCII dashes in PAUSED stage output (PR #177) - Add pytest-asyncio to dev dependencies for CI compatibility (PR #185) - Guard os.getuid()/os.getgid() for Windows in figure renderer
Jiaaqiliu
added a commit
that referenced
this pull request
Apr 1, 2026
Sync with upstream open source repo (10 commits): - feat: universal skill loading system with 20 built-in skills and A-Evolve integration - feat: A-Evolve agentic evolution skill from community contribution - fix: post-merge compatibility fixes for PRs #177, #180, #185 - fix: detect remote GPU hardware when ssh_remote mode is configured - fix: pause iterative refinement on ACP timeout (PR #177) - fix: unify pipeline domain checks on the profile detector (PR #180) - ci: add GitHub Actions workflow for automated testing (PR #185) - Remove HITL module (deleted by upstream), clean all references - Add 3 missing builtin skills (scientific-visualization/writing/statistical-reporting) - All 2504 tests pass, 0 failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
researchclaw.pipeline._domainhelper through the newerresearchclaw.domains.detectorprofile systemDomainProfileinstead of re-running the old coarse detectorWhy
AutoResearchClaw currently has two domain-detection paths in the pipeline:
stage-09/domain_profile.json_detect_domain()helper still used by some pipeline call sites, including the BenchmarkAgent gate in Stage 9That split can lead to contradictory behavior inside the same run. In one recent repair workflow for an engineering-drawing circle-localization project, Stage 9 persisted a detailed domain profile while BenchmarkAgent still followed the coarse path and proceeded under a different detector path. The root issue was that the pipeline was not actually using one shared detector.
This PR makes the old helper a compatibility wrapper around the canonical profile detector, then updates Stage 9 to reuse the already-computed profile when deciding whether BenchmarkAgent should run.
Changes
researchclaw/pipeline/_domain.pywith a compatibility wrapper aroundresearchclaw.domains.detectorml_vision/ml_tabularback to the legacy coarse tuple interface for older call sitesDomainProfilefor BenchmarkAgent gating inresearchclaw/pipeline/stage_impls/_experiment_design.pyValidation
python -m compileall researchclaw/pipeline/_domain.py researchclaw/pipeline/stage_impls/_experiment_design.py_detect_domain(...)now returns a coarse tuple derived from the same detector used by the profile system