feat: add strict parameter map in python - #274
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
domire8
commented
Apr 28, 2026
| py::class_<ParameterMap, std::shared_ptr<ParameterMap>, PyParameterMap> c(m, "ParameterMap"); | ||
|
|
||
| c.def(py::init(), "Empty constructor"); | ||
| c.def( |
Member
Author
There was a problem hiding this comment.
Here just fixing docstrings
domire8
commented
Apr 28, 2026
| this->set_attractor(parameter->get_parameter_value<JointState>()); | ||
| } else if (parameter->get_parameter_state_type() == StateType::JOINT_POSITIONS) { | ||
| this->set_attractor(parameter->get_parameter_value<JointPositions>()); | ||
| } else { |
Member
Author
There was a problem hiding this comment.
I made this addition to PointAttractor<CartesianState> in the other PR but not in the PointAttractor<JointState>
SprGrf
previously approved these changes
Apr 28, 2026
SprGrf
left a comment
SprGrf
left a comment
There was a problem hiding this comment.
Looks good, pending a changelog update
Member
Author
|
I omitted the changelog on purpose because it's already captured with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We overlooked two things in #265:
StrictParameterMapin pythoncopy_parameter_valuein pythonThis PR fixes that
Review guidelines
Estimated Time of Review: 5 minutes
Checklist before merging: