Repository navigation
tinyweb: example usage hints print from the monitor's listening callback - #3468
Merged
Merged
Conversation
The auth, composition, sse, static and websocket examples printed their curl hints before tw_start, so they appeared even when the bind failed and named a hard-coded port. They now print from http.monitor's listening callback with the bound port, as example_app does (#3224). Each failure path prints the reason. From Jules task 7158961981082754066 (paul-hammant#43). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TinyWeb examples' curl hints now print from
http.monitor'slisteningcallback, using the bound port, asexample_app.aehas since #3224. Before,example_auth,example_composition,example_sse,example_staticandexample_websocketprinted them beforetw_start, so they appeared even when the bind failed, and they hard-coded 8080.example_compositionalso now prints the reason when the bind fails.Drafted by Jules (paul-hammant#43), checked here:
example_appcompile;example_sserun briefly: the hints print after "Starting server…", from the callback;.github/scripts/contrib_check.sh: every tinyweb check passes (spec, inventory, integration, schema_api, streams, monitor).Changelog fragment under
changed(the CHANGELOG gate countscontrib/as shipped code).🤖 Generated with Claude Code