Repository navigation
test: accept matching runtime ABIs in the cross-version matrix - #3470
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI can build the same runtime ABI as the latest published release. The ABI matrix unconditionally expected the shared-runtime library and importer to reject that pairing, failing PR #3468 after 0.860.0 was published.
Read the runtime ABI IDs from the built library catalogs. Matching IDs must pass the host calls and Aether import; differing IDs retain the existing rejection checks. Compare full IDs so ABI revisions and layout flags remain significant. Update the ABI policy and add a changelog fragment.
Validation:
incsspqin panic handling on this host, so it could not complete this check here.sh tests/integration/abi_policy/test_abi_policy.shpasses.build/ae fmt std examples tests, shell syntax andgit diff --checkpass.make check-docspasses outside the sandbox (the sandbox prevented the UDP example from binding).