Skip to content

fix(protocol): align retry_after with the canonical error shape#5954

Merged
bokelley merged 2 commits into
mainfrom
codex/fix-retry-after-main
Jul 23, 2026
Merged

fix(protocol): align retry_after with the canonical error shape#5954
bokelley merged 2 commits into
mainfrom
codex/fix-retry-after-main

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Summary

  • align every maintained main-line reference with canonical top-level error.retry_after
  • correct the idempotency/rate-limit runner contracts and reviewer guidance
  • make RATE_LIMITED and IDEMPOTENCY_IN_FLIGHT metadata explicit about wire placement
  • remove unsupported integer-only wording without changing the canonical number schema

Why

Prose and compliance assets referenced error.details.retry_after, while core/error.json defines retry_after on the error object itself. The rate-limit harness therefore risked rejecting conformant sellers and rewarding the wrong wire shape.

Validation

  • schema validation
  • storyboard test kits, documentation parity, and check-enum tests
  • schema, compliance, and protocol-tarball builds
  • error-code drift and immutable-artifact checks
  • changeset scope/status checks
  • TypeScript and git diff --check

The separate number-versus-integer decision is tracked in #5953.

Main-line portion of #5948.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argus is not auto-reviewing this PR because it modifies protected paths that require human review (static/schemas/source/enums/error-code.json, static/schemas/source/protocol/get-adcp-capabilities-response.json). A human reviewer should review and merge this PR; Argus will resume on subsequent PRs once these changes land on main.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argus is not auto-reviewing this PR because it modifies protected paths that require human review (static/schemas/source/enums/error-code.json, static/schemas/source/protocol/get-adcp-capabilities-response.json). A human reviewer should review and merge this PR; Argus will resume on subsequent PRs once these changes land on main.

@andybevan-scope3

Copy link
Copy Markdown
Collaborator

This PR contains a single change - looks good to me

Problem: Our guidance told developers to read the “wait this long before trying again” hint from a different place than where the actual rules said to put it, so anyone following the instructions would look in the wrong spot and miss the hint entirely.
Fix: All the guidance and examples were updated to point at the one correct, standard location where that retry hint actually lives.

@bokelley
bokelley merged commit 0a51bac into main Jul 23, 2026
31 checks passed
@bokelley
bokelley deleted the codex/fix-retry-after-main branch July 23, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants