Skip to content

fix(compliance): validate top-level retry_after on 3.0.x#5955

Open
bokelley wants to merge 4 commits into
3.0.xfrom
codex/fix-retry-after-3-0
Open

fix(compliance): validate top-level retry_after on 3.0.x#5955
bokelley wants to merge 4 commits into
3.0.xfrom
codex/fix-retry-after-3-0

Conversation

@bokelley

Copy link
Copy Markdown
Contributor

Summary

  • restore the rate-limit trip runner source contract on the 3.0.x line
  • validate canonical top-level error.retry_after instead of the nonexistent nested path
  • correct the same path in the universal idempotency storyboard
  • remove integer-only assertions that the published numeric schema does not require

Why

The patch-line compliance source could mis-grade conformant sellers by looking under error.details.retry_after. The universal storyboard also referenced the wrong path, while its runner source contract was missing from this branch.

Validation

  • storyboard test kits: 12 passed
  • compliance build and included lints
  • changeset scope/status checks
  • git diff --check

No released dist artifact was modified and the number-versus-integer schema decision remains out of scope in #5953.

3.0.x portion of #5948. Merge the main-line fix #5954 first; the subsequent forward merge may require retaining main's broader corrected files.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Argus review could not complete

The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.

View workflow run

This is an automated message from the Argus AI review workflow.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argus is not auto-reviewing this PR because it modifies protected paths that require human review (.agents/playbook.md, .github/workflows/build-check.yml). A human reviewer should review and merge this PR; Argus will resume on subsequent PRs once these changes land on main.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Argus review could not complete

The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.

View workflow run

This is an automated message from the Argus AI review workflow.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Argus review could not complete

The automated review encountered an issue (possibly reached max turns, timed out, or failed to post the final gh pr review). A human reviewer should take this PR.

View workflow run

This is an automated message from the Argus AI review workflow.

@bokelley

Copy link
Copy Markdown
Contributor Author

CI follow-up: the first failure came from the legacy 3.0.x freshness gate rebuilding already-published dist/compliance/3.0.21. I reverted that generated artifact change and backported main's immutable-release guard instead, removing the obsolete gate. This preserves released artifacts and lets the changeset flow create 3.0.22. Local immutable-artifact tests and the branch-vs-base guard both pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant