Skip to content

fix(z-input): ensure password toggle allows pointer cancellation (WCAG 2.5.2) #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ada-workbackai wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −0
Open

fix(z-input): ensure password toggle allows pointer cancellation (WCAG 2.5.2) #613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e7491f
fix(z-input): ensure password toggle allows pointer cancellation
ada-workbackai Feb 14, 2026
95d243f
fix: add empty line before comment for stylelint
ada-workbackai Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/z-input/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,9 @@ export class ZInput {
}

private renderShowHidePassword(): HTMLButtonElement {
// WCAG 2.5.2 (Pointer Cancellation): onClick fires on pointer/touch up-event,
// allowing users to cancel by moving away before release. Do not add touchstart
// or pointerdown handlers that execute the toggle action.
return (
<button
type="button"
Expand Down
3 changes: 3 additions & 0 deletions src/components/z-input/styles-text.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@
.text-wrapper .icons-wrapper > button.reset-icon,
.text-wrapper .icons-wrapper > button.toggle-password-icon {
cursor: pointer;

/* WCAG 2.5.2: Prevent double-tap-to-zoom gesture from being confused with button activation */
touch-action: manipulation;
}

.text-wrapper .icons-wrapper > .input-icon {
Expand Down