fix(z-input): ensure password toggle allows pointer cancellation (WCAG 2.5.2)#613
Open
ada-workbackai wants to merge 2 commits intomasterfrom
Open
fix(z-input): ensure password toggle allows pointer cancellation (WCAG 2.5.2)#613ada-workbackai wants to merge 2 commits intomasterfrom
ada-workbackai wants to merge 2 commits intomasterfrom
Conversation
Adds touch-action: manipulation to password visibility toggle buttons to prevent double-tap-to-zoom delays and ensure proper pointer cancellation behavior per WCAG 2.5.2. Documents that onClick handler fires on up-event, allowing users to cancel the action by sliding away before release.
Addresses stylelint error: comment-empty-line-before
Contributor
Author
|
Fixed stylelint error by adding empty line before comment in styles-text.css. CI should pass now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes WCAG 2.5.2 (Pointer Cancellation) by ensuring password visibility toggle buttons respond only to pointer/touch up-events, allowing users to cancel actions by sliding away before release.
Issue: Password toggle buttons could execute actions immediately on touch down without allowing pointer cancellation, creating a CRITICAL security risk for accidental password reveals.
Solution:
touch-action: manipulationCSS property to prevent double-tap-to-zoom delays and ensure proper touch handlingonClickhandler fires on up-event (not down-event), allowing cancellationTest Plan
Evidence
View before/after screenshots and full audit details:
https://app.workback.ai/dashboard/issue/2583/
WCAG Reference:
2.5.2 Pointer Cancellation