fix: dispatch the release workflow after a trusted merge - #18
Merged
Merged
Conversation
release.yml's workflow_run trigger never actually fires here: merges are performed by auto-merge.yml using GITHUB_TOKEN, and GitHub deliberately does not let GITHUB_TOKEN pushes trigger further push-triggered workflow runs, so CI never reports a push event for a merge commit (the same reason cd.yml already carries a workflow_dispatch fallback and auto-merge.yml dispatches it explicitly). Give release.yml the matching workflow_dispatch input and dispatch it the same way. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releaseworkflow but it never actually fired after merging: it only had aworkflow_run: [CI]trigger, and this repo's merges are performed byauto-merge.ymlusingGITHUB_TOKEN. GitHub deliberately does not letGITHUB_TOKEN-authored pushes trigger further push-triggered workflow runs (to avoid recursive runs), so CI never reports apushevent for a merge commit here — confirmed bygh run list --workflow=CI, which shows every run aspull_request, neverpush.cd.ymlalready works around exactly this by also declaring aworkflow_dispatchinput and havingauto-merge.ymlcallgh workflow run cd.yml --ref main -f ref=<merge sha>right after merging. Applies the identical fix torelease.ymland adds the matching dispatch call inauto-merge.yml.workflow_runtrigger is kept as a harmless belt-and-suspenders path, matchingcd.yml's existing style.Test plan
ruff format --check .ruff check .mypyrelease.ymlonce to bootstrap the repo's first tag/release and confirm the pipeline end-to-end (no further feat/fix PR is queued to exercise the automatic path yet)