fix: use a lightweight tag so the release job needs no git identity - #19
Merged
Merged
Conversation
The runner has no configured git user.name/user.email, so an annotated tag (git tag -a) failed with "Committer identity unknown" the first time this ran. A lightweight tag needs no identity and the release notes already come from --generate-notes, so the annotated tag's message added nothing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymlafter PR fix: dispatch the release workflow after a trusted merge #18 merged to bootstrap the repo's first tag/release and verify the pipeline end-to-end. The bump logic worked correctly (computedv0.1.0), butgit tag -afailed with "Committer identity unknown" — the runner has nouser.name/user.emailconfigured, and an annotated tag needs one.git tag "$VERSION" "$RELEASE_SHA"), which needs no identity. The release notes already come fromgh release create --generate-notes, so the annotated tag's-mmessage added nothing.git push, so no tag or release exists yet.Test plan
ruff format --check .ruff check .release.ymlrelease.ymlagain to confirmv0.1.0is tagged and released