59710 wp privacy exports dir

[pbearne]

Trac ticket: https://core.trac.wordpress.org/ticket/59710

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, wildworks, mindctrl, masteradhoc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[masteradhoc]

@pbearne could you check the last feedback from @mindctrl? i'd like to milestone this for 7.1 so we can get this added soon.

[Copilot]

Pull request overview

Adds PHPUnit coverage for wp_privacy_exports_dir() to validate its default exports directory and the wp_privacy_exports_dir filter hook behavior.

Changes:

• Introduces a new unit test file for wp_privacy_exports_dir().
• Adds a test ensuring the wp_privacy_exports_dir filter can override the returned directory.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

tests/phpunit/tests/functions/wpPrivacyExportsDir.php:2

• Missing blank line after the opening <?php tag; other PHPUnit test files in this directory consistently include a blank line before the file header docblock, and this file currently starts the docblock immediately on the next line.

<?php
/**

tests/phpunit/tests/functions/wpPrivacyExportsDir.php:31

• remove_filter() is executed after the assertion, so if the assertion fails (or an exception occurs) the filter will remain registered and can leak into subsequent tests. Wrap the assertion block in a try/finally to guarantee cleanup.

		add_filter( 'wp_privacy_exports_dir', array( $this, 'filter_wp_privacy_exports_dir' ) );

		$expected_dir = '/wp-personal-data-exports-dir/';
		$actual_dir   = wp_privacy_exports_dir();
		$this->assertSame( $expected_dir, $actual_dir );

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

tests/phpunit/tests/functions/wpPrivacyExportsDir.php:31

• The test adds the wp_privacy_exports_dir filter but only removes it at the end of the method. If an assertion fails (or an unexpected exception occurs), the filter will remain in place and can leak into subsequent tests, causing unrelated failures. Wrap the assertions in a try/finally so the filter is always removed.

		add_filter( 'wp_privacy_exports_dir', array( $this, 'filter_wp_privacy_exports_dir' ) );

		$expected_dir = '/wp-personal-data-exports-dir/';
		$actual_dir   = wp_privacy_exports_dir();
		$this->assertSame( $expected_dir, $actual_dir );

[masteradhoc]

@pbearne Thank you! Could you check the PHP Unit Test Error?

There was 1 failure:

1) Tests_Functions_wpPrivacyExportsDir::test_wp_privacy_exports_dir_filtered
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'/wp-personal-data-exports-dir/'
+'/var/www/src/wp-content/uploads/filtered-exports/'

/var/www/tests/phpunit/tests/functions/wpPrivacyExportsDir.php:28
phpvfscomposer:///var/www/vendor/phpunit/phpunit/phpunit:106
/var/www/vendor/bin/phpunit:118

[t-hamano]

Could you check the PHP Unit Test Error?

I have fixed this.

[masteradhoc]

Thank you @t-hamano appreciate we can get this out :)

[github-actions]

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 63025
GitHub commit: 7d6fa3a

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.