test for wp_privacy_exports_url by pbearne · Pull Request #5551 · WordPress/wordpress-develop

pbearne · 2023-10-23T18:27:08Z

Trac ticket: https://core.trac.wordpress.org/ticket/59709

Co-authored-by: John Parris <public@johnparris.com>

github-actions · 2026-06-26T18:08:55Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @pbearne@git.wordpress.org.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, wildworks, mindctrl, jdstphen00, masteradhoc.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-06-26T18:13:18Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

…ic URL generation

…to 59709_wp_privacy_exports_url

masteradhoc · 2026-07-07T09:36:17Z

Thanks for the work @pbearne and the reviews @mindctrl. i'll milestone this for 7.1 now.

Copilot

Pull request overview

Adds PHPUnit coverage for wp_privacy_exports_url() (Trac #59709), ensuring the exports directory URL is generated correctly and can be overridden via the corresponding filter.

Changes:

Introduces a new PHPUnit test file for wp_privacy_exports_url().
Adds a test for the default URL construction and a test verifying the wp_privacy_exports_url filter behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mindctrl

Looks good overall. The remaining Copilot suggestions make sense.

t-hamano · 2026-08-02T09:21:08Z

Hi @pbearne, do you have the bandwidth to address the Copilot reviews?

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

pbearne · 2026-08-04T17:45:07Z

done

masteradhoc · 2026-08-04T18:32:46Z

~~@pbearne can you recheck? the last commit removed the } on line 22.~~

LGTM! @t-hamano can you recheck this one as well?

The `@group` annotation should reference the `functions` group rather than `functions.php`.

Filters added with `add_filter()` are already removed by the base test case's `tear_down()`, so the override is unnecessary.

The callback previously ignored its argument, so the value passed to the `wp_privacy_exports_url` filter was never verified. Deriving the return value from `$exports_url` closes that gap.

This adds coverage for the personal data exports directory URL, verifying both the default location under the uploads directory and that the filter of the same name can override it. Developed in: #5551 Follow-up to [63025]. Props desrosj, masteradhoc, mindctrl, pbearne, wildworks. Fixes #59709. git-svn-id: https://develop.svn.wordpress.org/trunk@63028 602fd350-edb4-49c9-b593-d223f7449a82

github-actions · 2026-08-05T13:04:23Z

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 63028
GitHub commit: 2768106

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.

This adds coverage for the personal data exports directory URL, verifying both the default location under the uploads directory and that the filter of the same name can override it. Developed in: WordPress/wordpress-develop#5551 Follow-up to [63025]. Props desrosj, masteradhoc, mindctrl, pbearne, wildworks. Fixes #59709. Built from https://develop.svn.wordpress.org/trunk@63028 git-svn-id: http://core.svn.wordpress.org/trunk@62247 1a063a9b-81f0-0310-95a4-ce76da25c4cd

pbearne added 2 commits October 23, 2023 14:26

test for wp_privacy_exports_url

25f8dc8

test for wp_privacy_exports_url

136b3e2

This comment was marked as spam.

Sign in to view

mindctrl suggested changes Jun 25, 2026

View reviewed changes

pbearne and others added 4 commits June 26, 2026 14:02

Update tests/phpunit/tests/functions/wpPrivacyExportsUrl.php

6da433e

Co-authored-by: John Parris <public@johnparris.com>

Update tests/phpunit/tests/functions/wpPrivacyExportsUrl.php

daae6ae

Co-authored-by: John Parris <public@johnparris.com>

Update tests/phpunit/tests/functions/wpPrivacyExportsUrl.php

aebe057

Co-authored-by: John Parris <public@johnparris.com>

Merge branch 'trunk' into 59709_wp_privacy_exports_url

3e7f3a9

Paul Bearne and others added 5 commits June 26, 2026 15:19

Update test_wp_privacy_exports_url to use wp_upload_dir for dynam…

9821765

…ic URL generation

Merge remote-tracking branch 'origin/59709_wp_privacy_exports_url' in…

6a5b6ff

…to 59709_wp_privacy_exports_url

Update wpPrivacyExportsUrl.php

340cf81

Change assertEquals to assertSame in test

a2ab74e

Fix formatting of tear_down method

0799382

pbearne requested a review from mindctrl June 26, 2026 20:44

mindctrl approved these changes Jul 1, 2026

View reviewed changes

pento force-pushed the trunk branch from 3af2d27 to 64ede28 Compare July 6, 2026 03:10

Merge branch 'trunk' into 59709_wp_privacy_exports_url

2ff25b9

Copilot AI review requested due to automatic review settings July 28, 2026 06:48

Copilot started reviewing on behalf of t-hamano July 28, 2026 06:49 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

Comment thread tests/phpunit/tests/functions/wpPrivacyExportsUrl.php Outdated

Comment thread tests/phpunit/tests/functions/wpPrivacyExportsUrl.php Outdated

Comment thread tests/phpunit/tests/functions/wpPrivacyExportsUrl.php

Comment thread tests/phpunit/tests/functions/wpPrivacyExportsUrl.php

mindctrl reviewed Jul 30, 2026

View reviewed changes

pbearne and others added 2 commits August 4, 2026 13:43

Apply suggestions from code review

c0eb98b

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Merge branch 'trunk' into 59709_wp_privacy_exports_url

080c998

Update wpPrivacyExportsUrl.php

9fc970e

t-hamano reviewed Aug 5, 2026

View reviewed changes

Comment thread tests/phpunit/tests/functions/wpPrivacyExportsUrl.php Outdated

Comment thread tests/phpunit/tests/functions/wpPrivacyExportsUrl.php Outdated

Comment thread tests/phpunit/tests/functions/wpPrivacyExportsUrl.php Outdated

t-hamano added 3 commits August 5, 2026 21:26

Tests: Correct the group annotation to functions.

8a127b0

The `@group` annotation should reference the `functions` group rather than `functions.php`.

Tests: Remove the redundant tear_down() method.

d501f65

Filters added with `add_filter()` are already removed by the base test case's `tear_down()`, so the override is unnecessary.

Tests: Derive the filtered URL from the filter argument.

4428823

The callback previously ignored its argument, so the value passed to the `wp_privacy_exports_url` filter was never verified. Deriving the return value from `$exports_url` closes that gap.

t-hamano approved these changes Aug 5, 2026

View reviewed changes

github-actions Bot closed this Aug 5, 2026

Uh oh!

Conversation

pbearne commented Oct 23, 2023

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

github-actions Bot commented Jun 26, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

masteradhoc commented Jul 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mindctrl left a comment

Choose a reason for hiding this comment

Uh oh!

t-hamano commented Aug 2, 2026

Uh oh!

pbearne commented Aug 4, 2026

Uh oh!

masteradhoc commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions Bot commented Jun 26, 2026 •

edited

Loading

masteradhoc commented Aug 4, 2026 •

edited

Loading