Repository navigation
fix(kit): a tracker CLI from a config builds, tests every option and passes cli-dev ready - #200
Merged
Merged
Conversation
…iled kind Found building linear-cli from a config (cli-template 0.31.0): - the Desktop sync line listed all seven tracker kinds, 64 characters, and pnpm generate stopped on desktop.sync.what (40 at most); it now keeps the kinds a sync reads last; - the tracker sync test passed while every kind failed on a misspelled variable: it read only issues, not each kind's error; - the GraphQL api test sampled every optional input field, and Linear's filters nest in each other until the worker ran out of memory; it now sends only the required variables; - cspell skips skills/*/references/api/, written from the service's own descriptions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…its for the pace Review follow-ups: optional plain fields still sent, object flags as JSON, meta.issues read where the sync answer has them, the api reference index skipped by cspell too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… a fake of its API Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s contract runs and ready verifies it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tests linear-cli's test matrix showed 562 options no test drove: --body-file and --all of the GraphQL api group, the tracker commands, session list, api list and --credential-storage. attio-cli wrote the same tests by hand. The seeds now carry them, so a CLI from a config starts with an empty untested list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e option is ignored A fresh review found: the tracker contract test runs over cli-core's GraphQL-only fake, so a tracker from an OpenAPI config failed every case; the --body-file run also passed the variables as flags, the --all check matched the previous call, and the session list check matched any text with the profile's name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
linear-cli is the first CLI from a config with the
trackercategory and agraphqlspec. Building it fromtemplate 0.31.0 hit gaps in the kit, each fixed here rather than in the CLI. The measurement:
WireCatLabs/cli-testing
performance/generation/linear-from-config(PR to follow).What
withSyncsdrops words from the front).trackerSourceContractover cli-core 0.701.0'strackerManifestFixture, and its sync testfails on a kind's error or
meta.issues. cli-base 0.119.0 makescli-dev readyask a tracker for that contract.apitest fits a large schema (Linear: 493 operations, its filters nest in each other) by samplingwhat an input requires, and sends object flags as JSON. No
apitest waits for the pace any more.--credential-storage,session list,api list, every GraphQL variable,--bodyand--body-file,--all, and each tracker command(
src/tracker-options.test.ts). linear-cli's test matrix went from 562 untested options to 0.new --from-configrefuses a tracker over OpenAPI: cli-core's tracker fake answers GraphQL only.Testing
pnpm ci:quick,pnpm lint,pnpm docs:check, 231 tests.pnpm kit:e2epassed with the seeds of f46f0b4 (four CLIs, among them a tracker from a config); the last committightened three seed assertions, run in linear-cli (496 api cases, session tests).
identifier()renames) and BUG-7 (one kind name over 35 letters) are left: neither occurs in Linear's schema.🤖 Generated with Claude Code