Repository navigation
fix(kit): a CLI made from a config passes its own coverage floor; kit:e2e makes two - #196
Merged
Merged
Conversation
…fy or source fails typecheck from-config.ts writes VERIFY and SOURCE with their own types when the config has them and a bare undefined when it does not, and HOOK_OPTIONS to spread into the source's options. The seed's guards against a missing value go, and one serviceFetch in the api group replaces four copies of the hosts-only fetch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…:e2e makes two A CRM or tracker CLI made by new --from-config with auth.verify failed pnpm test:coverage (a tracker reached 52% of branches against 75%): the seed held the token check and branches on the config's values that no test of that CLI can take both ways (FIND-2767). The check is cli-core's manifestVerify, the hosts-only fetch its hostsFetch, the CRM store its openAppStore, and the --offline refusal its refuseOffline. pnpm generate writes LIVE beside the exact types. New seed tests cover a sync before session start, --offline and api show. src/program.ts now hands the update check to run(): the daily notice never showed in a CLI made from the template. kit:e2e makes a CRM over an OpenAPI description and a tracker over a GraphQL schema with new --from-config, the spec answered from kit/test/from-config by a preload, and runs the same checks as the other two. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
A CLI made by
new --from-config(a CRM or tracker withauth.verify) must pass its own checks, andkit:e2emust check that path.Why
Such a CLI failed its own
pnpm test:coverage: a tracker reached 52% of branches against a floor of 75%. The seed held the token check andx ? { x } : {}branches on config values that no test of that CLI can take both ways.kit:e2enever made a CLI from a config, so nothing caught it.What
manifestVerify(cli-core #3110, released in 0.699.0);session.tsis one call. The hosts-only fetch ishostsFetch, the CRM storeopenAppStore, the--offlinerefusalrefuseOffline, all from cli-core.pnpm generatewrites the config's values with their exact types; one the config leaves out is a bareundefined, so a removedverifyfails typecheck. It also writesLIVEfor a CRM.src/program.tshands the update check torun(): the daily "a newer version exists" line never showed in a CLI made from the template.session startsays to sign in,--offlinesends nothing,api showworks without calling the service.kit:e2emakes a CRM over an OpenAPI description and a tracker over a GraphQL schema withnew --from-config(fixtures inkit/test/from-config/, the spec answered by a fetch preload) and runs the same checks as the other two.Testing
test:coverage: tracker lines 97.0%, branches 100%, functions 93.5%; CRM lines 96.8%, branches 100%, functions 93.5%. Left uncovered: the MCPsignedIncallback (run only by--profiles all, in a child process) and theupgradeinstall callback.🤖 Generated with Claude Code