Repository navigation
chore(deps): cli-base 0.111.0 - #3080
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ump needs no changelog entry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
added a commit
that referenced
this pull request
Nov 17, 2026
…ter URLs and fields (#3087) ## Task PR 5b of the source-manifest plan: a CLI built from `wirecat.config.ts` signs in with a real check of the token. The coordinator also asked for a fresh review of #3080 and of #3082's changes after its review; this PR applies what held up. ## What - **`auth.verify: { operation, id, name? }`** for `token` and `oauth2-pkce`: the operation that answers whose the token is, and where its answer holds the account's id and name. cli-template's generated `session start` checks a token with it (Attio `getV2Self`, Notion's users/me). - **`recalledAccount`** is exported from `@wirecat/cli-core/cli`: the account a profile signed in to, as `session start` remembered it. cli-template's CRM wiring keys the store by it. - **From the review:** - `spec.from`, `auth.revokeUrl` and a relay redirect take an https URL with a host, without spaces, a user name or password, or a key or token in its query (these would be committed into the CLI's files); - `hooks` takes a `.ts` or `.js` module under `./`, without `..`; - the schema's output is typed against `CliConfig` (a typed local, not a bare cast), so the two cannot drift; `parseCliConfig` still returns `CliConfig`, as cli-template's kit expects (the parity job caught a first attempt that changed it); - an unknown field reads "not a field of wirecat.config", a missing one "missing"; - the changelog says cli-core needs cli-base 0.112.0 or later (since 0.693.0). - Not taken: a CI check against the peer floor, and cli-template importing `CLI_CATEGORIES` (follow-ups). - **From a fresh review of this PR:** secret query names match whole words (`?design=1`, `?keyword=` pass; `?accessToken=` is refused); a `#fragment` is refused; `verify.id`/`name` must be dot paths; "missing" and "not a field" are chosen by the issue's shape, so `scopes: [undefined]` keeps valibot's words; `./.ts` and `.d.ts` hooks are refused. Not changed: the typed local catches drift one way only (comment narrowed); `recalledAccount` joins the profile name into a path as `rememberAccount` already did; whether every caller checks profile names is not verified here (a follow-up). ## Testing - `src/manifest/index.test.ts`: categories, crm with a source, `verify`, each refused URL, old and missing fields, `hooks` paths. - `pnpm typecheck`, lint, `docs:check`, `check:dist`, and the full suite: 12454 passed. The 2 failures, in `src/services/messages-transcript-words.test.ts`, pass alone (7/7). 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds and tests cli-core on cli-base 0.111.0 (codegen
Responses,examplesGenerator, ids for a spec with no operationId), so the next cli-core release and cli-template'snew --from-configuse one cli-base. Full suite locally: 12446 passed. No code change; peer range unchanged.🤖 Generated with Claude Code