Repository navigation
feat(manifest): auth.verify names the call that checks a token; stricter URLs and fields - #3087
Merged
Merged
Conversation
…ter URLs and fields A fresh review of #3080 and of #3082's changes after its review: spec.from, auth.revokeUrl and a relay redirect took an https URL with a user name, a key in its query, spaces or no host, all of which cli-template would commit; hooks took any path under ./; parseCliConfig typed an unchecked source as CrmManifest; and the changelog never said cli-core 0.693.0 needs cli-base 0.112.0. An unknown or missing field now reads as such. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…late's kit types against A typed local, not a cast, keeps the schema and CliConfig in step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…erify, key issues by shape From a fresh review of #3087: ?design=1 was refused as a secret, #access_token=… was let through, an empty verify id passed, and an undefined list item read "missing". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
PR 5b of the source-manifest plan: a CLI built from
wirecat.config.tssigns in with a real check of the token. The coordinator also asked for a fresh review of #3080 and of #3082's changes after its review; this PR applies what held up.What
auth.verify: { operation, id, name? }fortokenandoauth2-pkce: the operation that answers whose the token is, and where its answer holds the account's id and name. cli-template's generatedsession startchecks a token with it (AttiogetV2Self, Notion's users/me).recalledAccountis exported from@wirecat/cli-core/cli: the account a profile signed in to, assession startremembered it. cli-template's CRM wiring keys the store by it.From the review:
spec.from,auth.revokeUrland a relay redirect take an https URL with a host, without spaces, a user name or password, or a key or token in its query (these would be committed into the CLI's files);hookstakes a.tsor.jsmodule under./, without..;CliConfig(a typed local, not a bare cast), so the two cannot drift;parseCliConfigstill returnsCliConfig, as cli-template's kit expects (the parity job caught a first attempt that changed it);Not taken: a CI check against the peer floor, and cli-template importing
CLI_CATEGORIES(follow-ups).From a fresh review of this PR: secret query names match whole words (
?design=1,?keyword=pass;?accessToken=is refused); a#fragmentis refused;verify.id/namemust be dot paths; "missing" and "not a field" are chosen by the issue's shape, soscopes: [undefined]keeps valibot's words;./.tsand.d.tshooks are refused. Not changed: the typed local catches drift one way only (comment narrowed);recalledAccountjoins the profile name into a path asrememberAccountalready did; whether every caller checks profile names is not verified here (a follow-up).Testing
src/manifest/index.test.ts: categories, crm with a source,verify, each refused URL, old and missing fields,hookspaths.pnpm typecheck, lint,docs:check,check:dist, and the full suite: 12454 passed. The 2 failures, insrc/services/messages-transcript-words.test.ts, pass alone (7/7).🤖 Generated with Claude Code