Repository navigation
chore(release): 0.2.0 on cli-core 0.674.0, old caller ids moved to E.164, call fields - #34
Merged
Merged
Conversation
…-core 0.674.0 Builds before #19 stored a call's client as `phone:<10 national digits>`, and the one-day #18 build as `phone:+<10 digits>` (with the same wrong number in `identities.phone`). 0.1.0 writes `phone:+7…` via clientPhone(), so a sync over an old store added a second client per caller and its calls never linked to the CRM contact (the owner's store: ~1626 old ids). - store.ts: oldClientRekeys() maps both old forms to the clientPhone() id and phone; current E.164 ids and extensions stay. rekeyOldClients() lists every beeline identity (all profiles) and calls cli-core's store.people.rekeyIdentities in passes until every pair is taken; renamed, merged and refused counts only, never the ids (they are phone numbers). - meetings sync runs it after the store opens, before the pull, and prints the counts on stderr only when something moved. Idempotent: a second sync is quiet. - SourceMeeting.call = { direction in|out, clientPhone } (cli-core 0.674.0); the manager participant already had role `manager`. A re-sync rewrites an old call's title and fills its call fields (tested). - @wirecat/cli-core 0.671.0 -> 0.674.0 (store version 67); cli-base stays 0.103.0 (latest). Reusable workflows pinned to cli-base v0.103.0 (183e251), changelog guard included; covers Dependabot #22-#24. - Drop scripts/audit.sh (CI runs cli-dev audit --family directly) and its template.json entry. - Audit differences: drop meeting-project.stale and meeting_participants (no longer found); meeting and meeting_details differ from zm 0.77.0 (cli-core 0.667.0) until zm publishes on 0.674.0. - Changelog: 0.2.0 (not yet on npm) gains the call fields and the migration; README, README.ru and DESIGN say what sync does with old ids. Tests: src/client-rekey.test.ts on a temp store: both old forms renamed, an old id merged into the E.164 one already stored (participants move), an extension untouched, a second run all unchanged, call fields after a re-sync. Rules: WC-ARCH-21, WC-TEST-2, WC-DOC-3. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bin/beeline-live nbzb against the owner's Beeline account, read-only, in a throwaway store: session check, 245 calls synced with 0 warnings, the list carries call, one call transcribed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 16, 2026
Closed
chore(deps): Bump WireCatLabs/cli-base/.github/workflows/release-start.yml from 0.85.1 to 0.96.0
#23
Closed
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Round 3 (2026-11-16) for beeline: build on cli-core 0.674.0, move the callers that development builds of 0.1.0 stored
under old ids to their E.164 ids, set the call fields, and finish the 0.2.0 release, which is dated on
mainbut noton npm (both publish runs failed with E404 before npm trusted
release.yml).Why
phone:<10 national digits>; the one-day build of feat(meetings): link call clients to CRM contacts by phone; adopt cli-core 0.651.0 #18 wrotephone:+<10 digits>. 0.1.0 writesphone:+7…. A sync with 0.1.0 over an old store adds a second client percaller, and those calls never link to the CRM contact. The owner's store holds 1626 such ids.
call(direction,manager,client_phone) on meetings and on the CRMcontexts.
What
oldClientRekeys()insrc/store.tsmaps both old forms to the idclientPhone()gives and sets the right
phone. Current E.164 ids and extensions stay.rekeyOldClients()reads every beelineidentity (every profile) and calls
store.people.rekeyIdentitiesin passes until every pair is taken.meetings syncruns it after the store opens and before the pull. It printsmoved old caller ids to their E.164 numbers: N renamed, M mergedon stderr only when something moved. It prints counts only, never the ids, which arephone numbers. A second sync moves nothing and prints nothing.
SourceMeeting.call = { direction: "in" | "out", clientPhone }. The manager participant alreadyhad the role
manager. A re-sync rewrites an old call's title (the+9…form) and fills its call fields (tested).@wirecat/cli-core0.671.0 → 0.674.0.@wirecat/cli-baseis already 0.103.0, the latest.pnpm generate:docs/commands.mdcounts the newcallfield.183e251), the changelog guard included.This covers chore(deps): Bump WireCatLabs/cli-base/.github/workflows/node-ci.yml from 0.85.1 to 0.96.0 #22, chore(deps): Bump WireCatLabs/cli-base/.github/workflows/release-start.yml from 0.85.1 to 0.96.0 #23 and chore(deps): Bump WireCatLabs/cli-base/.github/workflows/release-checks.yml from 0.85.1 to 0.96.0 #24.
scripts/audit.shis removed, because CI runscli-dev audit --familyitself; itstemplate.jsonentry goes too. In
lint/audit-differences.json,meeting-project.staleandmeeting_participantsare gone (nolonger found).
meetingandmeeting_detailsdiffer from zm 0.77.0 (cli-core 0.667.0) until zm publishes on0.674.0.
releasescopebecause 0.2.0 is dated and not yet published. README, README.ru and DESIGN say what a sync does with old ids.
Rules: WC-ARCH-21, WC-TEST-2, WC-DOC-3, WC-CI-8, WC-REL-17.
Testing
src/client-rekey.test.ts, on a temporary store: both old forms renamed, with their participants; an old idmerged into the E.164 id already stored; an extension left alone; a second run all
unchanged; call fields and acorrected title after a re-sync.
node:sqlitewithreadOnly,oldClientRekeysfrom the build, noopenStore): 1641beeline identities. 1626 are in the old national form and 0 in the
+9…form. The migration would rename 1626 andmerge 0. 5
phone:ids that are not numbers (extensions) stay as they are.Conformance
pnpm release:checkpassed (VITEST_MAX_WORKERS=1) one step before 8bbbfd7, which only moved the new test's numbers into the gitleaks allowlist; that file andcalls.test.tsre-ran green on 8bbbfd7: 13 test files, 131 tests, lines 96.7%,branches 83.5%. Command lint ok. Family audit: 10 CLIs, 0 new findings that block. The test matrix, no-leak, docs,
generate, version and package checks pass.
pnpm peers checkis clean.bin/beeline-live nbzb, throwaway store):0.2.0 8bbbfd7fd044df87552c79ce8abea195e6100e48 2026-11-16 bin/beeline-live v2:eadc369017ed7ef2941f203c6521991eb8e3a6c05f0c98ffbd2ef655c590b516.session status --checkok.meetings syncsaved 245 meetings with 0 warnings.meetings listreturned 3, withcall.meetings transcribetranscribed 1 call, 0 failed.translations/pages/beeline/nordocs/compare.mdexists.docs/dev/skills/release/fresh-audit.mdas written. Its run ofrelease:checkpassed: 131 of 131 tests. It found 22 gaps: 15 in this repository (2 of them belong in cli-core) and7 in the handbook. None comes from this change. They are follow-ups, most already listed in chore(release): 0.2.0 on cli-core 0.671.0 and cli-base 0.103.0 #32:
meetings transcribeanswersaudio_seconds, andfailed[]has noref. WC-OUT-15:recording.too-longis not registered. WC-OUT-16 and WC-SECR-6:failed[].messagecopies any error's text.ascasts. WC-TEST-14: thecontracts:upgradeskip should end now that 0.1.0 is published. WC-TEST-19: the fake answers any path. WC-TEST-5 and WC-ARCH-10:
real timers in the API tests.
first-callsnamesno profile. WC-MCP-11: the MCP text names call comments and departments, which are never stored. WC-DOC-21: no
banner. WC-DOC-10: a CLAUDE.md rule repeats WC-REL-7.
against
README.ru.md, phone masking outside messengers (WC-SECR-8), computed data in WC-CMD-17, and WC-ARCH-23against the template.
🤖 Generated with Claude Code