Skip to content

chore(release): 0.2.0 on cli-core 0.674.0, old caller ids moved to E.164, call fields - #34

Merged
leemour merged 2 commits into
mainfrom
chore/round3-2026-11-16
Nov 16, 2026
Merged

leemour merged 2 commits into
mainfrom
chore/round3-2026-11-16

Conversation

@leemour

@leemour leemour commented Nov 16, 2026

Copy link
Copy Markdown
Member

Task

Round 3 (2026-11-16) for beeline: build on cli-core 0.674.0, move the callers that development builds of 0.1.0 stored
under old ids to their E.164 ids, set the call fields, and finish the 0.2.0 release, which is dated on main but not
on npm (both publish runs failed with E404 before npm trusted release.yml).

Why

What

  • Old caller ids → E.164. oldClientRekeys() in src/store.ts maps both old forms to the id clientPhone()
    gives and sets the right phone. Current E.164 ids and extensions stay. rekeyOldClients() reads every beeline
    identity (every profile) and calls store.people.rekeyIdentities in passes until every pair is taken.
    meetings sync runs it after the store opens and before the pull. It prints moved old caller ids to their E.164 numbers: N renamed, M merged on stderr only when something moved. It prints counts only, never the ids, which are
    phone numbers. A second sync moves nothing and prints nothing.
  • Call fields. SourceMeeting.call = { direction: "in" | "out", clientPhone }. The manager participant already
    had the role manager. A re-sync rewrites an old call's title (the +9… form) and fills its call fields (tested).
  • Dependencies. @wirecat/cli-core 0.671.0 → 0.674.0. @wirecat/cli-base is already 0.103.0, the latest.
    pnpm generate: docs/commands.md counts the new call field.
  • Workflows. Every cli-base reusable workflow is pinned to v0.103.0 (183e251), the changelog guard included.
    This covers chore(deps): Bump WireCatLabs/cli-base/.github/workflows/node-ci.yml from 0.85.1 to 0.96.0 #22, chore(deps): Bump WireCatLabs/cli-base/.github/workflows/release-start.yml from 0.85.1 to 0.96.0 #23 and chore(deps): Bump WireCatLabs/cli-base/.github/workflows/release-checks.yml from 0.85.1 to 0.96.0 #24.
  • Cleanup. scripts/audit.sh is removed, because CI runs cli-dev audit --family itself; its template.json
    entry goes too. In lint/audit-differences.json, meeting-project.stale and meeting_participants are gone (no
    longer found). meeting and meeting_details differ from zm 0.77.0 (cli-core 0.667.0) until zm publishes on
    0.674.0.
  • Docs. The 0.2.0 changelog section gains the call fields and the migration. This PR has the release scope
    because 0.2.0 is dated and not yet published. README, README.ru and DESIGN say what a sync does with old ids.

Rules: WC-ARCH-21, WC-TEST-2, WC-DOC-3, WC-CI-8, WC-REL-17.

Testing

  • src/client-rekey.test.ts, on a temporary store: both old forms renamed, with their participants; an old id
    merged into the E.164 id already stored; an extension left alone; a second run all unchanged; call fields and a
    corrected title after a re-sync.
  • Owner's store, read only (node:sqlite with readOnly, oldClientRekeys from the build, no openStore): 1641
    beeline identities. 1626 are in the old national form and 0 in the +9… form. The migration would rename 1626 and
    merge 0. 5 phone: ids that are not numbers (extensions) stay as they are.

Conformance

  • pnpm release:check passed (VITEST_MAX_WORKERS=1) one step before 8bbbfd7, which only moved the new test's numbers into the gitleaks allowlist; that file and calls.test.ts re-ran green on 8bbbfd7: 13 test files, 131 tests, lines 96.7%,
    branches 83.5%. Command lint ok. Family audit: 10 CLIs, 0 new findings that block. The test matrix, no-leak, docs,
    generate, version and package checks pass. pnpm peers check is clean.
  • Live check (read-only, with the owner's yes, bin/beeline-live nbzb, throwaway store):
    0.2.0 8bbbfd7fd044df87552c79ce8abea195e6100e48 2026-11-16 bin/beeline-live v2:eadc369017ed7ef2941f203c6521991eb8e3a6c05f0c98ffbd2ef655c590b516.
    session status --check ok. meetings sync saved 245 meetings with 0 warnings. meetings list returned 3, with
    call. meetings transcribe transcribed 1 call, 0 failed.
  • Comparison page (WC-CMP-11): none. Neither cli-docs translations/pages/beeline/ nor docs/compare.md exists.
  • Fresh audit: a new subagent, with the prompt in docs/dev/skills/release/fresh-audit.md as written. Its run of
    release:check passed: 131 of 131 tests. It found 22 gaps: 15 in this repository (2 of them belong in cli-core) and
    7 in the handbook. None comes from this change. They are follow-ups, most already listed in chore(release): 0.2.0 on cli-core 0.671.0 and cli-base 0.103.0 #32:
    • WC-OUT-13: meetings transcribe answers audio_seconds, and failed[] has no ref. WC-OUT-15:
      recording.too-long is not registered. WC-OUT-16 and WC-SECR-6: failed[].message copies any error's text.
    • WC-ARCH-16: the transport's message names a command. WC-STYLE-5: as casts. WC-TEST-14: the contracts:upgrade
      skip should end now that 0.1.0 is published. WC-TEST-19: the fake answers any path. WC-TEST-5 and WC-ARCH-10:
      real timers in the API tests.
    • WC-TEST-11: the coverage floors are far below the measured values. WC-ACCT-1 and WC-DOC-12: first-calls names
      no profile. WC-MCP-11: the MCP text names call comments and departments, which are never stored. WC-DOC-21: no
      banner. WC-DOC-10: a CLAUDE.md rule repeats WC-REL-7.
    • In cli-core: WC-LIFE-14, a meetings sync status command; WC-ARCH-4, the empty read-only store.
    • In the handbook: beeline is missing from several "applies to" lists, a stale WC-LIFE-17 exception, WC-DOC-13
      against README.ru.md, phone masking outside messengers (WC-SECR-8), computed data in WC-CMD-17, and WC-ARCH-23
      against the template.
  • Slice reviews: none. One slice: the migration and its test.

🤖 Generated with Claude Code

leemour and others added 2 commits November 16, 2026 13:36
…-core 0.674.0

Builds before #19 stored a call's client as `phone:<10 national digits>`, and
the one-day #18 build as `phone:+<10 digits>` (with the same wrong number in
`identities.phone`). 0.1.0 writes `phone:+7…` via clientPhone(), so a sync over
an old store added a second client per caller and its calls never linked to
the CRM contact (the owner's store: ~1626 old ids).

- store.ts: oldClientRekeys() maps both old forms to the clientPhone() id and
  phone; current E.164 ids and extensions stay. rekeyOldClients() lists every
  beeline identity (all profiles) and calls cli-core's
  store.people.rekeyIdentities in passes until every pair is taken; renamed,
  merged and refused counts only, never the ids (they are phone numbers).
- meetings sync runs it after the store opens, before the pull, and prints the
  counts on stderr only when something moved. Idempotent: a second sync is quiet.
- SourceMeeting.call = { direction in|out, clientPhone } (cli-core 0.674.0);
  the manager participant already had role `manager`. A re-sync rewrites an
  old call's title and fills its call fields (tested).
- @wirecat/cli-core 0.671.0 -> 0.674.0 (store version 67); cli-base stays
  0.103.0 (latest). Reusable workflows pinned to cli-base v0.103.0 (183e251),
  changelog guard included; covers Dependabot #22-#24.
- Drop scripts/audit.sh (CI runs cli-dev audit --family directly) and its
  template.json entry.
- Audit differences: drop meeting-project.stale and meeting_participants (no
  longer found); meeting and meeting_details differ from zm 0.77.0 (cli-core
  0.667.0) until zm publishes on 0.674.0.
- Changelog: 0.2.0 (not yet on npm) gains the call fields and the migration;
  README, README.ru and DESIGN say what sync does with old ids.

Tests: src/client-rekey.test.ts on a temp store: both old forms renamed, an
old id merged into the E.164 one already stored (participants move), an
extension untouched, a second run all unchanged, call fields after a re-sync.

Rules: WC-ARCH-21, WC-TEST-2, WC-DOC-3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bin/beeline-live nbzb against the owner's Beeline account, read-only, in a
throwaway store: session check, 245 calls synced with 0 warnings, the list
carries call, one call transcribed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​wirecat/​cli-core@​0.671.0 ⏵ 0.674.098 +1100100 +19670

View full report

@leemour
leemour merged commit e13bc31 into main Nov 16, 2026
26 of 27 checks passed
@leemour
leemour deleted the chore/round3-2026-11-16 branch November 16, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant