Skip to content

feat: keep transcribed recordings, number: ids, owner release script, upgrade contract - #35

Merged
leemour merged 5 commits into
mainfrom
feat/next-2026-11-16
Nov 16, 2026
Merged

leemour merged 5 commits into
mainfrom
feat/next-2026-11-16

Conversation

@leemour

@leemour leemour commented Nov 16, 2026

Copy link
Copy Markdown
Member

Task

One round of beeline work before 0.3.0: the owner's ruling on non-phone client numbers, the simple follow-ups of the fresh audits in #32 and #34, an owner release script, recordings kept for Desktop, and the "meetings in the manifest" commit from the other session (71a4502, merged in).

Why

  • cli-core's call reader keys a non-phone client as number:<raw>; beeline wrote phone:<raw> (owner ruling NEED-2620 A).
  • Owner ruling "1 A, но можно отменить в настройках": keep the recording after transcription so WireCat Desktop plays it like Asterisk's; a setting turns it off.
  • The owner publishes beeline by hand and runs the live check himself: one readable script, and the live-check record must not need its own PR/CI round.
  • contracts:upgrade was skipped in CI only until a version was published (WC-TEST-14).

What

  • number: ids — src/call-source.ts writes number:<raw>; oldClientRekeys (src/store.ts) also moves phone:<raw non-E.164> to number:<raw> through rekeyIdentities. E.164 ids stay.
  • Kept recordings — src/recordings.ts: after meetings transcribe, the recording goes to <beeline state>/recordings/<profile>/<call id>.mp3 (folder 0700, file 0600) and is saved as the call's recording attachment, so meetings show prints its local_path (cli-core 0.668.0). Profile setting keep_recordings (default true); false drops it as before. Desktop's call_recording.rs (branch feat/own-tool-meetings) plays it unchanged.
  • bin/owner-release <profile> — one Ruby file, each step printed: clean main fast-forwarded, Desktop ≥ 0.6.9 released, pnpm install --frozen-lockfile, version raised from changes/ (via scripts/version-level.ts and changelog-fragments.ts), pnpm build, sandboxed read-only live check (throwaway HOME/XDG/store, DBUS_SESSION_BUS_ADDRESS=disabled: on the beeline runs only, token from keyring beeline-cli/token:<profile>, counts only), cli-dev live record, release PR carrying the version and the record, squash merge, bin/release --local. bin/release is unchanged. bin/beeline-live still works; listed for removal.
  • contracts:upgrade — contracts/previous (0.2.0), contracts/seed.mjs syncs fake calls with the previous release's own modules, contracts/upgrade.json checks list/show/missing on the new build; CI skip removed.
  • Audit follow-ups — recording.too-long registered (WC-OUT-15); failed[].message only from our own errors (WC-OUT-16, WC-SECR-6); MCP untrusted text without comments/departments (WC-MCP-11); first-calls names a profile (WC-ACCT-1, WC-DOC-12); README.ru.md is a user page (WC-DOC-2); ci:quick builds once (WC-CI-4); coverage floors 96/94/93/82 (WC-TEST-11); workflow pins to cli-base v0.104.0 (WC-CI-14, no workflow file changed between the tags).
  • Template-owned files changed on purpose: .github/workflows/*.yml (pins, skip), docs/dev/TESTING.md, docs/dev/skills/release/SKILL.md (owner-release flow).
  • Changelog: changes/feat-next-2026-11-16.md (Added, Fixed) beside changes/feat-desktop-meetings.md.

Testing

  • pnpm test:coverage: 14 files, 136 tests; lines 96.75%, statements 94.31%, functions 94.44%, branches 83.42%.
  • New: src/client-rekey.test.ts (moved, merged into existing, second run unchanged, E.164 untouched); src/transcribe-command.test.ts (kept with 0600 and named in meetings show; dropped with the setting off).
  • lint, typecheck, standards:check, lint:commands, audit:commands, contracts:check, contracts:upgrade, test:matrix:check, docs:check, generate:check, version:check, security:no-leak, package:check, pnpm peers check: all pass.
  • bin/owner-release: ruby -wc; its version-raise step run in a scratch clone gave 0.3.0 with both fragments collected. The live, PR and publish steps are the owner's to run.

🤖 Generated with Claude Code

leemour and others added 5 commits November 16, 2026 14:29
…s a recording

Builds on cli-base 0.104.0. `src/wcat.ts` names the provider
(`meetingsProvider: "beeline"`), so `cli-dev manifest` writes
`desktop.meetings` into contracts/wirecat.json: WireCat Desktop (0.6.9 or
later) then links, opens and shows the transcript of a client's beeline
call from the Clients page and Meetings. Desktop 0.6.8 refuses a manifest
with this key, so release this after Desktop 0.6.9.

`syncs` is now "calls", a word Desktop counts with, instead of "recorded
calls", which it counted as "records".

`meetings download <call> --output <file>` saves one call's recording from
Beeline to a new private file (mode 0600, never over an existing file), so
the recording Desktop cannot play yet can be listened to from the CLI. It
is off MCP (an agent cannot name a file to write) and `--output` is
owner-only; permission key `meetings.download`. README and docs/security.md
say a recording now reaches disk only through it, and how to list a
client's calls by number (`meetings list 'title:*<number>'`).

WC-CMD-29, WC-PERM-22.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… upgrade contract

- Client numbers that are no phone numbers (extensions) are written as `number:<raw>`, the key cli-core's call
  reader expects; `meetings sync` moves the old `phone:<raw>` ids through rekeyIdentities (owner, NEED-2620 A).
- `meetings transcribe` keeps each recording in beeline's state folder (0700/0600) as the call's `recording`
  attachment with `local_path`, so Desktop plays it; profile setting `keep_recordings` (default true) turns it off.
- bin/owner-release: one Ruby file the owner runs — sync main, raise the version, build, sandboxed read-only live
  check, record it in the release commit, merge the release PR, bin/release --local. Refuses while the released
  Desktop is below 0.6.9.
- contracts:upgrade from 0.2.0 (seed through the previous release's own modules); CI skip removed (WC-TEST-14).
- Follow-ups: recording.too-long registered (WC-OUT-15), failed[].message only for own errors (WC-OUT-16,
  WC-SECR-6), MCP untrusted text (WC-MCP-11), first-calls names a profile (WC-ACCT-1, WC-DOC-12), README.ru.md a
  user page (WC-DOC-2), ci:quick builds once (WC-CI-4), coverage floors raised (WC-TEST-11), workflow pins to
  cli-base v0.104.0 (WC-CI-14).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​wirecat/​cli-base@​0.104.0981001009670
Added@​wirecat/​beeline-cli@​0.2.08210010090100

View full report

@leemour
leemour merged commit 12d4fe6 into main Nov 16, 2026
16 checks passed
@leemour
leemour deleted the feat/next-2026-11-16 branch November 16, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant