Repository navigation
feat: keep transcribed recordings, number: ids, owner release script, upgrade contract - #35
Merged
Merged
Conversation
…s a recording Builds on cli-base 0.104.0. `src/wcat.ts` names the provider (`meetingsProvider: "beeline"`), so `cli-dev manifest` writes `desktop.meetings` into contracts/wirecat.json: WireCat Desktop (0.6.9 or later) then links, opens and shows the transcript of a client's beeline call from the Clients page and Meetings. Desktop 0.6.8 refuses a manifest with this key, so release this after Desktop 0.6.9. `syncs` is now "calls", a word Desktop counts with, instead of "recorded calls", which it counted as "records". `meetings download <call> --output <file>` saves one call's recording from Beeline to a new private file (mode 0600, never over an existing file), so the recording Desktop cannot play yet can be listened to from the CLI. It is off MCP (an agent cannot name a file to write) and `--output` is owner-only; permission key `meetings.download`. README and docs/security.md say a recording now reaches disk only through it, and how to list a client's calls by number (`meetings list 'title:*<number>'`). WC-CMD-29, WC-PERM-22. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… upgrade contract - Client numbers that are no phone numbers (extensions) are written as `number:<raw>`, the key cli-core's call reader expects; `meetings sync` moves the old `phone:<raw>` ids through rekeyIdentities (owner, NEED-2620 A). - `meetings transcribe` keeps each recording in beeline's state folder (0700/0600) as the call's `recording` attachment with `local_path`, so Desktop plays it; profile setting `keep_recordings` (default true) turns it off. - bin/owner-release: one Ruby file the owner runs — sync main, raise the version, build, sandboxed read-only live check, record it in the release commit, merge the release PR, bin/release --local. Refuses while the released Desktop is below 0.6.9. - contracts:upgrade from 0.2.0 (seed through the previous release's own modules); CI skip removed (WC-TEST-14). - Follow-ups: recording.too-long registered (WC-OUT-15), failed[].message only for own errors (WC-OUT-16, WC-SECR-6), MCP untrusted text (WC-MCP-11), first-calls names a profile (WC-ACCT-1, WC-DOC-12), README.ru.md a user page (WC-DOC-2), ci:quick builds once (WC-CI-4), coverage floors raised (WC-TEST-11), workflow pins to cli-base v0.104.0 (WC-CI-14). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
One round of beeline work before 0.3.0: the owner's ruling on non-phone client numbers, the simple follow-ups of the fresh audits in #32 and #34, an owner release script, recordings kept for Desktop, and the "meetings in the manifest" commit from the other session (71a4502, merged in).
Why
number:<raw>; beeline wrotephone:<raw>(owner ruling NEED-2620 A).contracts:upgradewas skipped in CI only until a version was published (WC-TEST-14).What
src/call-source.tswritesnumber:<raw>;oldClientRekeys(src/store.ts) also movesphone:<raw non-E.164>tonumber:<raw>throughrekeyIdentities. E.164 ids stay.src/recordings.ts: aftermeetings transcribe, the recording goes to<beeline state>/recordings/<profile>/<call id>.mp3(folder 0700, file 0600) and is saved as the call'srecordingattachment, someetings showprints itslocal_path(cli-core 0.668.0). Profile settingkeep_recordings(defaulttrue);falsedrops it as before. Desktop'scall_recording.rs(branchfeat/own-tool-meetings) plays it unchanged.bin/owner-release <profile>— one Ruby file, each step printed: clean main fast-forwarded, Desktop ≥ 0.6.9 released,pnpm install --frozen-lockfile, version raised fromchanges/(viascripts/version-level.tsandchangelog-fragments.ts),pnpm build, sandboxed read-only live check (throwaway HOME/XDG/store,DBUS_SESSION_BUS_ADDRESS=disabled:on the beeline runs only, token from keyringbeeline-cli/token:<profile>, counts only),cli-dev live record, release PR carrying the version and the record, squash merge,bin/release --local.bin/releaseis unchanged.bin/beeline-livestill works; listed for removal.contracts/previous(0.2.0),contracts/seed.mjssyncs fake calls with the previous release's own modules,contracts/upgrade.jsonchecks list/show/missing on the new build; CI skip removed.recording.too-longregistered (WC-OUT-15);failed[].messageonly from our own errors (WC-OUT-16, WC-SECR-6); MCP untrusted text without comments/departments (WC-MCP-11);first-callsnames a profile (WC-ACCT-1, WC-DOC-12);README.ru.mdis a user page (WC-DOC-2);ci:quickbuilds once (WC-CI-4); coverage floors 96/94/93/82 (WC-TEST-11); workflow pins to cli-base v0.104.0 (WC-CI-14, no workflow file changed between the tags)..github/workflows/*.yml(pins, skip),docs/dev/TESTING.md,docs/dev/skills/release/SKILL.md(owner-release flow).changes/feat-next-2026-11-16.md(Added, Fixed) besidechanges/feat-desktop-meetings.md.Testing
pnpm test:coverage: 14 files, 136 tests; lines 96.75%, statements 94.31%, functions 94.44%, branches 83.42%.src/client-rekey.test.ts(moved, merged into existing, second run unchanged, E.164 untouched);src/transcribe-command.test.ts(kept with 0600 and named inmeetings show; dropped with the setting off).lint,typecheck,standards:check,lint:commands,audit:commands,contracts:check,contracts:upgrade,test:matrix:check,docs:check,generate:check,version:check,security:no-leak,package:check,pnpm peers check: all pass.bin/owner-release:ruby -wc; its version-raise step run in a scratch clone gave 0.3.0 with both fragments collected. The live, PR and publish steps are the owner's to run.🤖 Generated with Claude Code