Skip to content

Dev #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chendelin1982 merged 2 commits into from
Apr 30, 2026
+10 −10
Merged

Dev #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc1d25d
fix web test
Apr 30, 2026
9b5a4dd
fix ci
Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/publish-images.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ jobs:
provenance: false

- name: Summarize published tags
env:
PUBLISHED_TAGS: ${{ steps.meta.outputs.tags }}
run: |
Comment on lines 117 to 120
Copy link
Copy Markdown
Contributor Author

@chendelin1982 chendelin1982 Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

{
echo "### Published Images"
Expand All @@ -123,9 +125,7 @@ jobs:
echo "Commit: ${{ steps.meta.outputs.COMMIT_SHA }}"
echo ""
echo "Tags:"
while IFS= read -r tag; do
printf '%s\n' "$PUBLISHED_TAGS" | while IFS= read -r tag; do
echo "- \`${tag}\`"
done <<'EOF'
${{ steps.meta.outputs.tags }}
EOF
done
} >> "$GITHUB_STEP_SUMMARY"
12 changes: 6 additions & 6 deletions web/src/pages/deploy/CreateDeploymentPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,9 +395,9 @@ describe('CreateDeploymentPage', () => {
app_required_disk_gib: '',
},
})
expect(
screen.queryByText('Create blocked by preflight: Preflight completed with warnings')
).not.toBeInTheDocument()
expect(screen.getByRole('alert')).not.toHaveTextContent(
'Create blocked by preflight: Preflight completed with warnings'
)
Comment thread
chendelin1982 marked this conversation as resolved.
})

it('blocks create when estimated app disk exceeds available disk', async () => {
Expand Down Expand Up @@ -484,9 +484,9 @@ describe('CreateDeploymentPage', () => {
'/api/actions/install/manual-compose',
expect.anything()
)
expect(
screen.getByText('Create blocked by preflight: Preflight found blocking issues')
).toBeInTheDocument()
expect(await screen.findByRole('alert')).toHaveTextContent(
'Create blocked by preflight: Preflight found blocking issues'
)
expect(
screen.getByText(
'Application estimated disk requirement (2147483648 bytes) exceeds available disk space (1073741824 bytes)'
Expand Down
Loading