Dev#1
Merged
chendelin1982 merged 2 commits intomainfrom Apr 30, 2026
Merged
Conversation
added 2 commits
April 30, 2026 09:11
There was a problem hiding this comment.
Pull request overview
This PR updates a UI test assertion around preflight notices on the deployment creation page and adjusts the GitHub Actions workflow step that summarizes published Docker image tags.
Changes:
- Update
CreateDeploymentPagetests to assert notice behavior viarole="alert"instead of direct text queries. - Refactor the
publish-imagesworkflow summary step to read tags from an environment variable rather than a heredoc.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
web/src/pages/deploy/CreateDeploymentPage.test.tsx |
Adjusts assertions for preflight notice rendering/absence using role="alert". |
.github/workflows/publish-images.yml |
Refactors published-tag summary loop to consume tags via PUBLISHED_TAGS env var. |
Comment on lines
117
to
120
| - name: Summarize published tags | ||
| env: | ||
| PUBLISHED_TAGS: ${{ steps.meta.outputs.tags }} | ||
| run: | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change in 2-5 lines.
What Changed
Why
Explain the problem, requirement, or risk this PR addresses.
Validation
make lintmake test backendmake test webmake e2eAdditional validation notes:
Risk Review
Contract Review
AI Assistance
Notes on AI usage:
Reviewer Checklist