Skip to content

Dev#1

Merged
chendelin1982 merged 2 commits intomainfrom
dev
Apr 30, 2026
Merged

Dev#1
chendelin1982 merged 2 commits intomainfrom
dev

Conversation

@chendelin1982
Copy link
Copy Markdown
Contributor

Summary

Describe the change in 2-5 lines.

What Changed

Why

Explain the problem, requirement, or risk this PR addresses.

Validation

  • make lint
  • make test backend
  • make test web
  • make e2e
  • Other validation noted below

Additional validation notes:


Risk Review

  • User-facing impact:
  • Data or migration impact:
  • CI/release impact:
  • Rollback plan:

Contract Review

  • No API or schema contract changed
  • OpenAPI or generated contract artifacts were updated
  • Release notes or changelog impact was reviewed
  • No release/distribution behavior changed

AI Assistance

  • No AI assistance was used
  • AI helped draft code or tests
  • AI helped draft PR text or review notes
  • AI output was manually reviewed and corrected where needed

Notes on AI usage:


Reviewer Checklist

  • Scope is small enough to review safely
  • Validation is appropriate for the changed surface
  • New behavior is covered by tests or explicitly justified
  • Docs/workflows/contracts were updated if behavior changed
  • Rollback or follow-up risk is acceptable

Copilot AI review requested due to automatic review settings April 30, 2026 09:23
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates a UI test assertion around preflight notices on the deployment creation page and adjusts the GitHub Actions workflow step that summarizes published Docker image tags.

Changes:

  • Update CreateDeploymentPage tests to assert notice behavior via role="alert" instead of direct text queries.
  • Refactor the publish-images workflow summary step to read tags from an environment variable rather than a heredoc.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
web/src/pages/deploy/CreateDeploymentPage.test.tsx Adjusts assertions for preflight notice rendering/absence using role="alert".
.github/workflows/publish-images.yml Refactors published-tag summary loop to consume tags via PUBLISHED_TAGS env var.

Comment thread web/src/pages/deploy/CreateDeploymentPage.test.tsx
Comment on lines 117 to 120
- name: Summarize published tags
env:
PUBLISHED_TAGS: ${{ steps.meta.outputs.tags }}
run: |
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link
Copy Markdown
Contributor Author

@chendelin1982 chendelin1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@chendelin1982 chendelin1982 merged commit 6621212 into main Apr 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants