Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,7 @@ Use this handy checklist to make sure your new instructions are fully supported:
- [ ] JS API tested in test/binaryen.js/kitchen-sink.js
- [ ] Tests added in test/spec
- [ ] Tests added in test/lit
- [ ] Tests are used as seeds for the fuzzer. If V8 doesn't support the
test, or if the new instruction isn't guarded by a wasm-validator check,
then either add the corresponding feature to DISALLOWED_FEATURES_IN_V8 or
mark the test as unfuzzable.
1 change: 1 addition & 0 deletions scripts/bundle_clusterfuzz.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
'--disable-stack-switching',
'--disable-relaxed-atomics',
'--disable-multibyte',
'--disable-wide-arithmetic',
]

with tarfile.open(output_file, "w:gz") as tar:
Expand Down
1 change: 1 addition & 0 deletions scripts/clusterfuzz/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
'--disable-strings',
'--disable-stack-switching',
'--disable-relaxed-atomics',
'--disable-wide-arithmetic',
]


Expand Down
5 changes: 3 additions & 2 deletions scripts/fuzz_opt.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
'stack-switching',
'relaxed-atomics',
'multibyte',
'wide-arithmetic',
]


Expand Down Expand Up @@ -916,7 +917,7 @@ def can_run(self, wasm):
if random.random() < 0.5:
return False
# wasm2c doesn't support most features
return all_disallowed(['exception-handling', 'simd', 'threads', 'bulk-memory', 'nontrapping-float-to-int', 'tail-call', 'sign-ext', 'reference-types', 'multivalue', 'gc', 'custom-descriptors', 'relaxed-atomics'])
return all_disallowed(['exception-handling', 'simd', 'threads', 'bulk-memory', 'nontrapping-float-to-int', 'tail-call', 'sign-ext', 'reference-types', 'multivalue', 'gc', 'custom-descriptors', 'relaxed-atomics', 'wide-arithmetic'])

@override
def run(self, wasm):
Expand Down Expand Up @@ -1237,7 +1238,7 @@ def can_run_on_wasm(self, wasm):
# implement wasm suspending using JS async/await.
if JSPI:
return False
return all_disallowed(['exception-handling', 'simd', 'threads', 'bulk-memory', 'nontrapping-float-to-int', 'tail-call', 'sign-ext', 'reference-types', 'multivalue', 'gc', 'multimemory', 'memory64', 'custom-descriptors', 'relaxed-atomics'])
return all_disallowed(['exception-handling', 'simd', 'threads', 'bulk-memory', 'nontrapping-float-to-int', 'tail-call', 'sign-ext', 'reference-types', 'multivalue', 'gc', 'multimemory', 'memory64', 'custom-descriptors', 'relaxed-atomics', 'wide-arithmetic'])


# Returns the wat for a wasm file. If it is already wat, it just returns that
Expand Down
Loading