Disable wide arithmetic in fuzzers#8663
Merged
Merged
Conversation
kripken
reviewed
Apr 30, 2026
| - [ ] Binary writing added in src/wasm-stack.h and src/wasm/wasm-stack.cpp | ||
| - [ ] Support added in various classes inheriting OverriddenVisitor (and possibly other non-OverriddenVisitor classes as necessary) | ||
| - [ ] Support added to src/tools/fuzzing.h | ||
| - [ ] If adding tests before fuzzing support, mark the test as unfuzzable first. |
Member
There was a problem hiding this comment.
Suggested change
| - [ ] If adding tests before fuzzing support, mark the test as unfuzzable first. | |
| - [ ] If adding tests before fuzzing support, mark the test as unfuzzable first, or the feature as not supported in v8 (`DISALLOWED_FEATURES_IN_V8`). |
Member
Author
There was a problem hiding this comment.
Rephrased this and mentioned DISALLOWED_FEATURES_IN_V8.
kripken
approved these changes
Apr 30, 2026
stevenfontanella
force-pushed
the
fuzzer
branch
from
2e728d2 to
450926e
Compare
Member
Author
|
@kripken I went with the other approach that you mentioned, does it look good? |
kripken
approved these changes
Apr 30, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
is the PR still a draft, btw?
Member
|
Kind of weird github lets you request a review for a PR that is marked draft and even has a button "ready for review"... |
stevenfontanella
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #8638 (comment). Part of #8544.