Port all compatible pass tests to lit#8185
Closed
stevenfontanella wants to merge 2 commits into
Closed
Conversation
75e5da5 to
00e0da7
Compare
00e0da7 to
209b116
Compare
Member
|
We last tried to do this in #3966, where we decided it would make more sense to this in reviewable chunks. That led to e.g. #3970, #3971, #3987, #4008, #4202, and finally #4219, which is still open because there was an actual question about the output 😅 If you were wondering where the catch was, there it is 😬 |
Member
Author
|
Got it, I was wondering why it hadn't been done already :) I'll close this and continue in other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python3 scripts/port_passes_tests_to_lit.py test/passes/*.wasttest/passes/simplify-locals-notee-nostructure.wastandtest/passes/simplify-locals-notee.txt test/passes/simplify-locals-notee.wastwere excluded since they don't pass after porting. The remaining tests weren't able to be ported by the scripts e.g.