Port pass tests that use safe heap + threads to lit#8184
Merged
Conversation
stevenfontanella
force-pushed
the
port-test
branch
from
311524a to
06b53ce
Compare
Member
|
@kripken, any concerns here? |
tlively
approved these changes
Jan 8, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
LGTM. We could have much more manageable tests if SafeHeap only added the functions it actually used, but that's probably not worth the effort in practice. Maybe we should add --remove-unused-module-elements to the tests instead?
Member
|
No concerns from me. I would actually not add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8169. Part of #8165. Remaining tests are ported in #8185.