-
Notifications
You must be signed in to change notification settings - Fork 859
Fix cross-module return_calls in the interpreter #8083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
|
|
||
| ;; RUN: wasm-opt %s -all --fuzz-exec-before --fuzz-exec-second=%s.second -q -o /dev/null 2>&1 | filecheck %s | ||
|
|
||
| (module | ||
| (import "fuzzing-support" "log-i32" (func $log-i32 (param i32))) | ||
|
|
||
| (global $global funcref (ref.func $func)) | ||
|
|
||
| (export "global" (global $global)) | ||
|
|
||
| (func $func | ||
| (call $log-i32 | ||
| (i32.const 42) | ||
| ) | ||
| ) | ||
| ) | ||
|
|
||
| ;; Export a funcref through a global, and return_call it from the other module. | ||
| ;; It must be called ok, print 42, and not error. | ||
|
|
||
| ;; CHECK: [fuzz-exec] calling caller | ||
| ;; CHECK-NEXT: [LoggingExternalInterface logging 42] | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| (module | ||
| (type $func (func)) | ||
|
|
||
| (import "primary" "global" (global $gimport funcref)) | ||
|
|
||
| (table $table 10 funcref) | ||
|
|
||
| (func $caller (export "caller") | ||
| ;; Do an indirect call from the table, writing the imported funcref first. | ||
| (table.set $table | ||
| (i32.const 1) | ||
| (global.get $gimport) | ||
| ) | ||
| (return_call_indirect (type $func) | ||
| (i32.const 1) | ||
| ) | ||
| ) | ||
| ) | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes! I wonder if this could be avoided with an abstract base class or something like that.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the templating makes that messy, or at least I can't find a good solution. Trying both natural and artificial intelligence, the best idea is multiple inheritance, which I'm not sure I like...
But open to improving this if we find something.