Fix cross-module return_calls in the interpreter#8083
Merged
Conversation
tlively
approved these changes
Dec 2, 2025
|
|
||
| if (nextData->self != this) { | ||
| // This function is in another module. Call from there. | ||
| auto other = (decltype(this))nextData->self; |
Member
There was a problem hiding this comment.
Yikes! I wonder if this could be avoided with an abstract base class or something like that.
Member
Author
There was a problem hiding this comment.
Hmm, the templating makes that messy, or at least I can't find a good solution. Trying both natural and artificial intelligence, the best idea is multiple inheritance, which I'm not sure I like...
But open to improving this if we find something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the return-called method is from another module, we need to call
from that runner instance.