Skip to content

fix(ConceptMap): Cannot open editing view #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hirokiterashima merged 2 commits into from
Feb 23, 2026
Merged

fix(ConceptMap): Cannot open editing view #2274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edf0174
fix(ConceptMap): Cannot open editing view
hirokiterashima Feb 23, 2026
d4293be
Updated messages
github-actions[bot] Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,10 @@ export class ConceptMapStudent extends ComponentStudent {
ngOnDestroy(): void {
super.ngOnDestroy();
const svg = this.getElementById(this.svgId, true);
svg.removeEventListener('dragover', this.dragOverListenerFunction);
svg.removeEventListener('drop', this.dropListenerFunction);
if (svg) {
svg.removeEventListener('dragover', this.dragOverListenerFunction);
svg.removeEventListener('drop', this.dropListenerFunction);
}
}

initialize(): void {
Expand Down
14 changes: 7 additions & 7 deletions src/messages.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2712,7 +2712,7 @@ Click &quot;Cancel&quot; to keep the invalid JSON open so you can fix it.</sourc
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts</context>
<context context-type="linenumber">416</context>
<context context-type="linenumber">418</context>
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/openResponse/edit-open-response-advanced/edit-open-response-advanced.component.html</context>
Expand Down Expand Up @@ -10541,11 +10541,11 @@ Click &quot;Cancel&quot; to keep the invalid JSON open so you can fix it.</sourc
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts</context>
<context context-type="linenumber">425</context>
<context context-type="linenumber">427</context>
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts</context>
<context context-type="linenumber">434</context>
<context context-type="linenumber">436</context>
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/match/match-authoring/match-authoring.component.html</context>
Expand Down Expand Up @@ -16800,7 +16800,7 @@ Are you ready to receive feedback on this answer?</source>
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts</context>
<context context-type="linenumber">350</context>
<context context-type="linenumber">352</context>
</context-group>
</trans-unit>
<trans-unit id="3308736994783976865" datatype="html">
Expand Down Expand Up @@ -17723,7 +17723,7 @@ Label: <x id="PH" equiv-text="linkLabel"/></source>
<source>You have no more chances to receive feedback on your answer.</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts</context>
<context context-type="linenumber">344</context>
<context context-type="linenumber">346</context>
</context-group>
</trans-unit>
<trans-unit id="1088900768760788337" datatype="html">
Expand All @@ -17732,7 +17732,7 @@ Label: <x id="PH" equiv-text="linkLabel"/></source>
Are you ready to receive feedback on this answer?</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts</context>
<context context-type="linenumber">347</context>
<context context-type="linenumber">349</context>
</context-group>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/openResponse/open-response-student/open-response-student.component.ts</context>
Expand All @@ -17743,7 +17743,7 @@ Are you ready to receive feedback on this answer?</source>
<source>Are you sure you want to reset your work?</source>
<context-group purpose="location">
<context context-type="sourcefile">src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts</context>
<context context-type="linenumber">1433</context>
<context context-type="linenumber">1435</context>
</context-group>
</trans-unit>
<trans-unit id="4145474018067473865" datatype="html">
Expand Down