Skip to content

Comments

fix(ConceptMap): Cannot open editing view#2274

Merged
hirokiterashima merged 2 commits intodevelopfrom
issue-2273-cannot-edit-concept-map
Feb 23, 2026
Merged

fix(ConceptMap): Cannot open editing view#2274
hirokiterashima merged 2 commits intodevelopfrom
issue-2273-cannot-edit-concept-map

Conversation

@hirokiterashima
Copy link
Member

It looks like this was introduced when this component was converted to standalone. A NPE was thrown, which prevented the editing view from being displayed

Changes

  • Add null check in case svg element isn't on the page when ngOnDestroy() is called

Test

  • Concept map editing view is rendered and works as before

Closes #2273

It looks like this was introduced when this component was converted to
standalone
@hirokiterashima hirokiterashima self-assigned this Feb 23, 2026
@hirokiterashima hirokiterashima added the bug Something isn't working label Feb 23, 2026
@qltysh
Copy link

qltysh bot commented Feb 23, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
New file Coverage rating: F
...onceptMap/concept-map-student/concept-map-student.component.ts33.3%128-129
Total33.3%
🤖 Increase coverage with AI coding...

In the `issue-2273-cannot-edit-concept-map` branch, add test coverage for this new code:

- `src/assets/wise5/components/conceptMap/concept-map-student/concept-map-student.component.ts` -- Line 128-129

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review February 23, 2026 21:56
@hirokiterashima hirokiterashima merged commit 2b728d4 into develop Feb 23, 2026
1 check passed
@hirokiterashima hirokiterashima deleted the issue-2273-cannot-edit-concept-map branch February 23, 2026 21:57
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.209.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(ConceptMap): Cannot open editing view

1 participant