Skip to content

chore: stabilize emoji picker scrolling tests #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nperez0111 merged 1 commit into from
Nov 3, 2026
Merged

chore: stabilize emoji picker scrolling tests #3292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tests/src/end-to-end/emojipicker/emojipicker.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,13 @@ describe("Check Emoji Picker Functionality", () => {
] as const) {
if (top === 0) {
await userEvent.keyboard("{ArrowDown}".repeat(12));
// Wait for the final row to mount and its keyboard scroll to finish
// before testing manual scrolling; key delivery alone doesn't wait
// for Frimousse's virtualization and the selection effect.
await waitForSelector(
'[aria-rowindex="13"] .bn-frimousse-emoji[data-selected]',
);
await waitForSelectedEmoji();
await scrollTo(0);
}
await vi.waitFor(() => {
Expand Down Expand Up @@ -538,7 +545,7 @@ describe("Check Emoji Picker Functionality", () => {
test("should scroll to a mounted emoji without estimating its position", async () => {
await focusOnEditor();
await userEvent.keyboard(":an");
await waitForSelector(".bn-frimousse-emoji[data-selected]");
await waitForSelectedEmoji();
const viewport = await waitForSelector("[frimousse-viewport]");
viewport.scrollTop = 96;
for (let frame = 0; frame < 3; frame++) {
Expand Down
Loading