[nperez0111]

Summary

• Wait for the final keyboard-selected emoji row and accessibility state before testing manual scrolling.
• Wait for the initial selection effect in the mounted-emoji scroll test.
• Preserve all existing scroll assertions; fix test synchronization rather than changing picker behavior.

Addresses the emoji-picker Chromium failure in main CI run https://github.com/TypeCellOS/BlockNote/actions/runs/41460622797.

Verification

• 87 emoji-picker tests passed in Docker across Chromium, Firefox, and WebKit with retries disabled.
• Reproduced the neighboring Firefox scroll-test failure before its readiness fix and verified it passes afterward.
• Targeted lint, formatting, and git diff checks pass.

Summary by CodeRabbit

• Tests
  • Improved emoji picker test timing around keyboard selection and manual scrolling.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
blocknote	Ready	Preview	Nov 3, 2026 9:37am UTC
blocknote-website	Ready	Preview	Nov 3, 2026 9:37am UTC

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The emoji picker end-to-end tests now wait for selection effects to complete after keyboard navigation. A direct selector wait is replaced with waitForSelectedEmoji().

Changes: Emoji picker test synchronization

Layer / File(s)	Summary
Synchronize selected-emoji checks tests/src/end-to-end/emojipicker/emojipicker.test.tsx	After navigating to the final row, the test waits for a selected emoji to mount and for waitForSelectedEmoji() to resolve before manual scrolling. Another test uses waitForSelectedEmoji() instead of a direct selector wait.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related PRs

• TypeCellOS/BlockNote#3121: Adds the emoji picker and the waitForSelectedEmoji() helper used by these tests.

Suggested reviewers: matthewlipski

Merge Risk: Minimal · up to add86

The changes improve test synchronization while preserving scrolling checks. No actionable merge-blocking risk is identified; merge after normal checks pass.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: stabilizing emoji picker scrolling tests.
Description check		The description explains the test synchronization changes, rationale, impact, affected CI failure, and verification results. It does not use every template heading and omits the checklist and screensh…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the test synchronization changes, rationale, impact, affected CI failure, and verification results. It does not use every template heading and omits the checklist and screenshots section, but it provides the critical information required for this test-only change.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit taps through rows of cheer,
Then waits for chosen sprites to appear.
The scrolling test resumes its flight,
With selection settled, clear and right.
One helper keeps the checks in sight.}

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: d956e310-b90f-4c03-bf81-e8f89f5bcb21

Commits

Reviewing files that changed from the base of the PR and between a04d254 and add86fb.

Files selected for processing: 1

• tests/src/end-to-end/emojipicker/emojipicker.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

[pkg-pr-new]

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/@blocknote/ariakit@3292

@blocknote/code-block

npm i https://pkg.pr.new/@blocknote/code-block@3292

@blocknote/core

npm i https://pkg.pr.new/@blocknote/core@3292

@blocknote/diagram-block

npm i https://pkg.pr.new/@blocknote/diagram-block@3292

@blocknote/mantine

npm i https://pkg.pr.new/@blocknote/mantine@3292

@blocknote/math-block

npm i https://pkg.pr.new/@blocknote/math-block@3292

@blocknote/react

npm i https://pkg.pr.new/@blocknote/react@3292

@blocknote/server-util

npm i https://pkg.pr.new/@blocknote/server-util@3292

@blocknote/shadcn

npm i https://pkg.pr.new/@blocknote/shadcn@3292

@blocknote/xl-ai

npm i https://pkg.pr.new/@blocknote/xl-ai@3292

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/@blocknote/xl-docx-exporter@3292

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/@blocknote/xl-email-exporter@3292

@blocknote/xl-multi-column

npm i https://pkg.pr.new/@blocknote/xl-multi-column@3292

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/@blocknote/xl-odt-exporter@3292

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/@blocknote/xl-pdf-exporter@3292

@blocknote/xl-typst-exporter

npm i https://pkg.pr.new/@blocknote/xl-typst-exporter@3292

commit: add86fb

[github-actions]

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-11-03 09:46 UTC