Skip to content

Simplify AudioTransport initialization for the client-only app - #126

Closed
TrySound wants to merge 6 commits into
test/player-06-platform-recoveryfrom
refactor/player-audio-instance-init
Closed

TrySound wants to merge 6 commits into
test/player-06-platform-recoveryfrom
refactor/player-audio-instance-init

Conversation

@TrySound

Copy link
Copy Markdown
Owner

Stack

Follow-up to #125; leaves the published six-PR stack unchanged.

Changes

  • Create one const AudioTransport in App component instance scope, not module scope or onMount.
  • Remove optional initialization state, guards and fallback accesses.
  • Preserve mount-time attachment before session startup and explicit detach-before-dispose cleanup.
  • Add App lifetime/reactivity/binding-cleanup regression.

SSR is explicitly not a requirement. No lazy factory, SSR guard, new dependency, or visible UI change.

Validation

  • pnpm check
  • pnpm test: 1,228 passed; focused lifecycle/audio: 139 passed
  • pnpm build
  • pnpm --filter @libras/website build
  • Fresh independent correctness/simplicity review approved.

Native-browser tests not rerun for this initialization-only refactor; existing platform verification limitations remain unchanged.

@TrySound

Copy link
Copy Markdown
Owner Author

Folded the initialization simplification and its lifecycle regression into the dedicated audio-transport PR #120. Restacked and pushed #121–#125 atomically with guarded leases; the final repository tree is byte-for-byte identical to this PR. Closing this redundant follow-up; no changes were dropped.

@TrySound TrySound closed this Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant