Skip to content

Player 1/6: Extract standalone native audio transport - #120

Open
TrySound wants to merge 8 commits into
mainfrom
refactor/player-01-audio-transport
Open

TrySound wants to merge 8 commits into
mainfrom
refactor/player-01-audio-transport

Conversation

@TrySound

@TrySound TrySound commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Stack

Depends on #114. First of six incremental player simplification PRs; no framework migration.

Changes

  • Extract a concrete app-owned AudioTransport with one native audio element.
  • Keep keyboard and Media Session in the thin headless binding.
  • Preserve cancellation, source cleanup, seek/fallback/retry behavior and demo support.

Validation

  • pnpm check
  • pnpm test: 1,224 passed; targeted audio/Media Session: 71 passed
  • pnpm build
  • pnpm --filter @libras/website build
  • Fresh independent simplicity/correctness review: approved.

Existing autofocus warning unchanged. Physical device playback verification remains pending; platform tests/documentation are planned in the final stack PR.

Initialization simplification folded into this PR

Includes the reviewed change formerly in #126: one component-instance const AudioTransport, no optional initialization state/guards, mount-time attachment and detach-before-dispose cleanup. SSR is not required. #121–#125 have been restacked; the final stack tree is unchanged.

Base automatically changed from feat/search-type-filters to main November 16, 2026 15:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant