Skip to content

Fixed the parse5 version hard-coded in the function-tracing test #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aileen merged 1 commit into from
Nov 11, 2026
Merged

Fixed the parse5 version hard-coded in the function-tracing test #398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/algolia-netlify/test/function-tracing.acceptance.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {execFile} from 'node:child_process';
import {readFile, rm} from 'node:fs/promises';
import {createRequire} from 'node:module';
import path from 'node:path';
import {promisify} from 'node:util';
import {fileURLToPath} from 'node:url';
Expand All @@ -17,6 +18,15 @@ const extractorDistDirectory = path.resolve(
// The workspace root has no netlify binary; resolve the pinned CLI from this package so the
// test does not depend on a globally installed netlify-cli.
const netlifyBinary = path.join(packageDirectory, 'node_modules/.bin/netlify');
// Resolve parse5 the way the extractor does, so the expected archive path tracks
// the installed version instead of hard-coding one.
const extractorRequire = createRequire(
path.join(workspaceDirectory, 'packages/algolia-html-extractor/package.json')
);
const parse5ArchivePath = path
.relative(workspaceDirectory, extractorRequire.resolve('parse5'))
.split(path.sep)
.join('/');

describe('Netlify function dependency tracing', () => {
beforeEach(async () => {
Expand All @@ -36,9 +46,7 @@ describe('Netlify function dependency tracing', () => {

expect(archiveIndex).toContain('packages/algolia-fragmenter/lib/index.mjs');
expect(archiveIndex).toContain('packages/algolia-html-extractor/dist/index.mjs');
expect(archiveIndex).toContain(
'node_modules/.pnpm/parse5@8.0.1/node_modules/parse5/dist/index.js'
);
expect(archiveIndex).toContain(parse5ArchivePath);
expect(archiveIndex).not.toContain('algolia-html-extractor@0.0.1');
expect(archiveIndex).not.toContain(workspaceDirectory);
}
Expand Down
Loading