Repository navigation
Fixed the parse5 version hard-coded in the function-tracing test - #398
Merged
Merged
Conversation
✅ Deploy Preview for alg-helpcenter ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 22 minutes for your next included review. View limit details
Pre-merge checks:
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
This assessment has not completed. The check will be retried on the next pre-merge check run. | |
| Description check | |
This assessment has not completed. The check will be retried on the next pre-merge check run. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
aileen
changed the title
`function-tracing.acceptance.test.mjs` asserted the literal pnpm store path `node_modules/.pnpm/parse5@8.0.1/...` inside the packaged function archive, so every Renovate bump of parse5 failed CI even though the tracing itself worked. The expected path is now derived at test time by resolving parse5 from the extractor package, which keeps asserting that the exact installed parse5 build is traced into the archive while following whatever version the lockfile carries. On the current lockfile the derived path is byte-identical to the removed literal, so the assertion's strength is unchanged.
aileen
force-pushed
the
aileen/renovate-ci-root-causes
branch
from
November 11, 2026 10:50
fd2599b to
d1f4204
Compare
aileen
enabled auto-merge (squash)
November 11, 2026 10:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #390 and #396: the remaining Renovate PR failures had two causes; this PR fixes the one that needs a code change.
Hard-coded parse5 version (#370).
function-tracing.acceptance.test.mjsasserted the literal archive pathnode_modules/.pnpm/parse5@8.0.1/..., so every parse5 bump failed. The expected path is now derived by resolving parse5 from the extractor package at test time; on the current lockfile the derived value is byte-identical to the old literal, and it tracks future bumps automatically. The tracing test runs in the netlify deploy-build simulation, which only works from standard clones, so this PR's own CI run is the end-to-end check.Fresh-release failures (#391/#392/#393) need no change. pnpm 12's default 24-hour
minimumReleaseAgerejects packages published less than a day ago (ERR_PNPM_MINIMUM_RELEASE_AGE_VIOLATION). That is the policy working as intended: those PRs simply wait until the release ages out and their next rebase goes green (nx 24.0.6 and netlify-cli 27.17.0 are already past the window; vite 8.3.8 ages out at 02:46 UTC). An earlier revision of this PR mirrored the window in renovate.json; that was deliberately dropped — we comply with the default policy and let young PRs wait.