Skip to content

fix(collaboration): bound legacy lease reads without losing visible continuations - #181

Merged
LIghtJUNction merged 6 commits into
integrate/all-open-20260929from
fix/lease-list-bounds-20260929
Sep 29, 2026
Merged

LIghtJUNction merged 6 commits into
integrate/all-open-20260929from
fix/lease-list-bounds-20260929

Conversation

@LIghtJUNction

Copy link
Copy Markdown
Contributor

Scope and dependency

Refs #81 #85. Narrow follow-up to #176; includes and preserves #180 head 63bafb4fdc352accd2115307f1373c28c89f92bd rather than rebuilding its changes. Merge #180 first when its exact gates pass; this PR then reduces to the collaboration slice. Do not close the broad acceptance issues.

Head 70d46ce, tree 6fb1502404967778e6e533faf414866557b80a3b.

  • Legacy communication.lease_list@1 previously materialized every lease for the holder before applying limit or current visibility. Read at most128 SQL rows per batch, scan using actual last-seen IDs, retain current target authorization for every candidate, and look ahead for a visible item before returning next_after.
  • Enforce the existing execution deadline and a4096-row scan budget with explicit query_cost_exceeded. Return continuation from the last visible lease, not a hidden resource; preserve active/expired/released projection and v1 output. No v2 Resource, state-machine, handoff, schema or authorization changes.
  • Real PostgreSQL/signed regression fixtures cover129 hidden leases spanning batches, visible continuations, all-hidden results, expiry/release, complete row-value invariance and no outbound effects. Additional expired-clock injection tests require rejection before lease SQL while retaining real principal/runtime/authentication checks.

Cloud evidence

RED run 36573737687 at test-only headfd4cde5809e44215d9687858429ea697baae436d/tree3a28244429f0e6e5ff3a7bf0fc531ac6411a531e: 13 cases, exactly2 failures,0 errors,0 skips; both failures independently capture the exact missing-LIMIT SQL, not merely an internal_error. Downloaded artifact11036112969 SHA256 84d1745fdd62f383396479358293752bbb9582d5b4073e3b6994110b158b0ffe verified with source/JUnit. Other11 existing collaboration tests pass.

Current focused run 36574509686 has been triggered; result and final combined full gates are not yet claimed GREEN. Preserve the complete four-shard exact node-ID gate, conformance/tokenizer, package builds and applicable specialist checks on the final source.

Runtime source is exactly blobf978dc61c866d1c48fab2e3a87979b67d7a8273e/SHA256ac4247f5629403942506a80c895e4018db4ec56d3a2e279a11a6fedbbef3b74d. Auxiliary source-only preparation publishes a single hash-constrained blob, never changes refs and is absent from the product tree. All project execution occurs in cloud CI.

Live progress note: #81 comment5890957893. No production deployment, Root/PIN, real funds, external delivery or recovery promotion.

…ery effect guards

Use no seek predicate for the initial page and actual cursor keys for continuations. Keep runtime-generation checks real in effect-order regression coverage, with explicit stale-generation rejection. Add PostgreSQL ordering/Unicode pagination and cloud-only regression evidence.

Refs #78 #82 #83 #85
Correct the focused workflow diagnostic without bypassing failures or changing runtime source/test assertions. Preserve verified prior RED evidence and active run references in the existing progress note.
… on real PostgreSQL

Cover 129 hidden leases across a batch boundary, visible/expired/released records, precise bounded SQL, continuous pagination and full read-only evidence. Runtime repair follows cloud RED evidence.

Refs #81 #85
…on fixes

Preserve both regression-first and PR #180 histories. Scan at most 128 rows per query, apply current target visibility per row, enforce a 4096-row/monotonic deadline budget, and return continuation only from a visible lease. Preserve existing v1 output and v2 Resource contracts.

Cloud RED 36573737687: 13 cases, exactly two explicit unbounded SQL failures, no errors/skips. Runtime source SHA256 ac4247f5629403942506a80c895e4018db4ec56d3a2e279a11a6fedbbef3b74d; no unrelated handoff changes.

Refs #81 #85
LIghtJUNction added a commit that referenced this pull request Sep 29, 2026
…atest read integration

Retain #180 f304bcf and #181 70d46ce histories without changing either branch. Work request/offer/checkpoint/proposal readers use bounded 128-row keyset scans, current row authorization/projection, 4096-candidate and monotonic-deadline budgets. Preserve their existing output/schema/state transitions.

Cloud RED 36576545310 at dd441ea: 15 real PostgreSQL/signed cases, exactly five unbounded-SQL failures, no errors/skips. Artifact11038236899 ZIP SHA256 71adea8a6611c11fe1fd82f13900e0e48b224038b610ed66530bde3129198c12 independently checked with source/JUnit. Add pre-query and mid-scan deadline regressions for each work kind.

Refs #78 #81 #82 #83 #85
@LIghtJUNction
LIghtJUNction merged commit 70d46ce into integrate/all-open-20260929 Sep 29, 2026
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant