Skip to content

fix(cover-letter): 자소서 입력 하드닝 재머지 (#129 누락분) #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i3months merged 1 commit into from
Jun 29, 2026
Merged

fix(cover-letter): 자소서 입력 하드닝 재머지 (#129 누락분) #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions backend/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3229,14 +3229,17 @@
"type" : "object",
"properties" : {
"title" : {
"type" : "string"
"type" : "string",
"maxLength" : 200,
"minLength" : 0
},
"items" : {
"type" : "array",
"items" : {
"$ref" : "#/components/schemas/Item"
},
"minItems" : 1
"maxItems" : 30,
"minItems" : 0
}
},
"required" : [ "items" ]
Expand All @@ -3245,10 +3248,14 @@
"type" : "object",
"properties" : {
"question" : {
"type" : "string"
"type" : "string",
"maxLength" : 500,
"minLength" : 0
},
"answer" : {
"type" : "string"
"type" : "string",
"maxLength" : 5000,
"minLength" : 0
}
}
},
Expand Down
3 changes: 2 additions & 1 deletion backend/src/main/java/com/stackup/stackup/coverletter/application/CoverLetterService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ private List<CoverLetterItem> parse(String json) {
try {
return JSON.readValue(json, ITEM_LIST);
} catch (JsonProcessingException e) {
log.warn("cover letter items parse failed, return empty. raw={}", json, e);
// 자소서 답변 본문(PII)은 로그에 남기지 않는다 — 길이만 기록.
log.warn("cover letter items parse failed, return empty. length={}", json.length(), e);
return List.of();
}
}
Expand Down
13 changes: 10 additions & 3 deletions .../main/java/com/stackup/stackup/coverletter/presentation/dto/CoverLetterCreateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,21 @@

import com.stackup.stackup.coverletter.application.dto.CoverLetterCreateCommand;
import com.stackup.stackup.coverletter.application.dto.CoverLetterItem;
import jakarta.validation.Valid;
import jakarta.validation.constraints.NotEmpty;
import jakarta.validation.constraints.Size;
import java.util.List;

// 서버측 입력 상한 — JSON @RequestBody 는 multipart 20MB 제한이 적용되지 않으므로
// 거대 payload(DoS·AI 비용 증폭)를 bean-validation 으로 차단한다. 상한은 프론트 입력 캡과 일치.
public record CoverLetterCreateRequest(
String title,
@NotEmpty List<Item> items
@Size(max = 200) String title,
@NotEmpty @Size(max = 30) List<@Valid Item> items
) {
public record Item(String question, String answer) {
public record Item(
@Size(max = 500) String question,
@Size(max = 5000) String answer
) {
}

public CoverLetterCreateCommand toCommand() {
Expand Down