fix(cover-letter): 자소서 입력 하드닝 재머지 (#129 누락분)#130
Merged
Conversation
회의적 max 리뷰(3/3·2/3 검증) 통과 결함 수정. - [HIGH] 자소서 생성 API 서버측 입력 상한 부재(JSON @RequestBody 는 multipart 20MB 미적용 → DoS/AI 비용 증폭). CoverLetterCreateRequest 에 bean-validation: title @SiZe(200), items @notempty @SiZe(max=30) + List<@Valid Item>, Item.question @SiZe(500)/answer @SiZe(5000). title 200자 초과도 이제 400(기존 500). - [MEDIUM] 파싱 실패 로그에 자소서 답변 본문(PII) 평문 기록 → 길이만 기록으로 변경. 백엔드 전체 테스트 통과, OpenAPI(maxLength)·프론트 타입 재생성, 프론트 빌드 통과. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경 사항
#129(자소서) 리뷰 후 푸시했던 하드닝 커밋이 dev 머지에 누락된 것을 발견 → 재머지. (커밋
2ff40ffcherry-pick)회의적 max 리뷰(3/3·2/3 검증)에서 잡힌 결함:
@RequestBody는 multipart 20MB 제한이 적용되지 않아 거대 payload(DoS·AI 비용 증폭) 가능.CoverLetterCreateRequest에 bean-validation 추가:title @Size(200),items @NotEmpty @Size(max=30)+List<@Valid Item>,Item.question @Size(500)/answer @Size(5000). (title 200자 초과도 이제 400, 기존 500)검증: 컴파일 통과(원 커밋은 백엔드 전체 테스트 통과 상태였음), OpenAPI maxLength 포함.
🤖 Generated with Claude Code