Skip to content

fix(examples): migrate remaining legacy createEffect calls to Solid 2.0 two-phase signature #8223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryansolid wants to merge 1 commit into
base: solid-router-v2-pre
Choose a base branch
from
+12 −8
Open

fix(examples): migrate remaining legacy createEffect calls to Solid 2.0 two-phase signature #8223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions examples/solid/kitchen-sink-solid-query-file-based/src/hooks/useSessionStorage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ export function useSessionStorage<T>(key: string, initialValue: T) {
stored ? JSON.parse(stored) : initialValue,
)

Solid.createEffect(() => {
sessionStorage.setItem(key, JSON.stringify(state()))
}, [state()])
Solid.createEffect(
() => JSON.stringify(state()),
(json) => sessionStorage.setItem(key, json),
)

return [state, setState]
}
4 changes: 2 additions & 2 deletions ...es/solid/kitchen-sink-solid-query-file-based/src/routes/dashboard.invoices.$invoiceId.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function InvoiceComponent() {
const updateInvoiceMutation = useUpdateInvoiceMutation(params().invoiceId)
const [notes, setNotes] = Solid.createSignal(search().notes ?? '')

Solid.createEffect(() => {
Solid.createEffect(notes, () => {
navigate({
search: (old) => ({
...old,
Expand All @@ -47,7 +47,7 @@ function InvoiceComponent() {
replace: true,
params: true,
})
}, [notes])
})

return (
<form
Expand Down
9 changes: 6 additions & 3 deletions examples/solid/start-bun/src/routes/demo.start.api-request.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,12 @@ export const Route = createFileRoute('/demo/start/api-request')({
function Home() {
const [names, setNames] = createSignal<Array<string>>([])

createEffect(() => {
getNames().then(setNames)
}, [])
createEffect(
() => {},
() => {
getNames().then(setNames)
},
)

return (
<div
Expand Down
Loading