Skip to content

fix(examples): migrate remaining legacy createEffect calls to Solid 2.0 two-phase signature - #8223

Open
ryansolid wants to merge 1 commit into
TanStack:solid-router-v2-prefrom
ryansolid:fix/solid-examples-createeffect-rc6
Open

fix(examples): migrate remaining legacy createEffect calls to Solid 2.0 two-phase signature#8223
ryansolid wants to merge 1 commit into
TanStack:solid-router-v2-prefrom
ryansolid:fix/solid-examples-createeffect-rc6

Conversation

@ryansolid

Copy link
Copy Markdown

Summary

Follow-up to the rc.6 bump: three example call sites still use React-style createEffect(fn, depsArray) / single-argument forms that SolidJS 2.0.0-rc.6 no longer accepts (the deprecated overload was removed from @solidjs/signals types, and side effects in the compute phase don't run reliably under 2.0 semantics).

These escaped CI because the affected examples build with plain vite build (no tsc --noEmit step):

  • examples/solid/kitchen-sink-solid-query-file-based/src/hooks/useSessionStorage.tsx — compute returns the serialized value, effect writes to sessionStorage
  • examples/solid/kitchen-sink-solid-query-file-based/src/routes/dashboard.invoices.$invoiceId.tsxcreateEffect(notes, () => navigate(...)), matching the style already used in kitchen-sink-file-based
  • examples/solid/start-bun/src/routes/demo.start.api-request.tsx — mount-time one-shot: empty compute, fetch in the effect phase

Examples-only change; no package sources touched.

Made with Cursor

…lid 2.0 two-phase signature

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: f9b31fe6-516b-4877-9782-fd2848508cdf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 64e8aa7

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 2m 19s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-03 01:46:30 UTC

@pkg-pr-new

pkg-pr-new Bot commented Sep 3, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@8223

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@8223

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@8223

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@8223

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@8223

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@8223

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@8223

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@8223

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@8223

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@8223

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@8223

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@8223

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@8223

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@8223

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@8223

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@8223

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@8223

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@8223

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@8223

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@8223

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@8223

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@8223

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@8223

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@8223

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@8223

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@8223

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@8223

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@8223

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@8223

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@8223

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@8223

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@8223

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@8223

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@8223

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@8223

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@8223

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@8223

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@8223

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@8223

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@8223

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@8223

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@8223

commit: 64e8aa7

@ryansolid
ryansolid marked this pull request as ready for review September 3, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants