fix(examples): migrate remaining legacy createEffect calls to Solid 2.0 two-phase signature - #8223
Conversation
…lid 2.0 two-phase signature Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 64e8aa7
☁️ Nx Cloud last updated this comment at |
Summary
Follow-up to the rc.6 bump: three example call sites still use React-style
createEffect(fn, depsArray)/ single-argument forms that SolidJS 2.0.0-rc.6 no longer accepts (the deprecated overload was removed from@solidjs/signalstypes, and side effects in the compute phase don't run reliably under 2.0 semantics).These escaped CI because the affected examples build with plain
vite build(notsc --noEmitstep):examples/solid/kitchen-sink-solid-query-file-based/src/hooks/useSessionStorage.tsx— compute returns the serialized value, effect writes tosessionStorageexamples/solid/kitchen-sink-solid-query-file-based/src/routes/dashboard.invoices.$invoiceId.tsx—createEffect(notes, () => navigate(...)), matching the style already used inkitchen-sink-file-basedexamples/solid/start-bun/src/routes/demo.start.api-request.tsx— mount-time one-shot: empty compute, fetch in the effect phaseExamples-only change; no package sources touched.
Made with Cursor