Repository navigation
chore: bump pinned Node to 24.22.1 - #1914
Conversation
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update Node.js version and prerequisites .nvmrc, CONTRIBUTING.md, CLAUDE.md, examples/ts-code-mode-web/README.md |
.nvmrc now specifies Node.js 24.22.1. The setup instructions refer to the version in .nvmrc. The Node 22 Nx warning remains unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Other
Suggested reviewers: alemtuzlak
Merge Risk: 
Minimal · up to 38ee2
-
The version update is internally consistent and presents no actionable merge risk.
Pre-merge checks: 
5
-
Full details: Title check
-
Explanation
The title "chore: bump pinned Node to 24.22.1" matches the main change. The PR changes the pinned Node version in
.nvmrcfrom 24.8.0 to 24.22.1. It also updates the docs that referred to the pinned version, so they now point to.nvmrc. The title is short, specific, and uses the conventional commit style.
Full details: Description check
-
Explanation
The description follows the template structure. It has the Changes section, which lists each file and explains why the docs now point to
.nvmrc. It has the Checklist, with every item marked and an explanation for the tests and docs. It has the Release Impact section, with the docs/CI/dev-only option checked. It also adds Testing and Risk/rollback sections. The author gives reasons where the template asks for them, such as why no docs or changeset were added. The changeset checkbox is marked as checked while the release impact section says no published package changed. This is a minor inconsistency, but the check still passes because the description is mostly complete.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
Smol change, just seemed sensible to align with latest node lts. I have some more work related to #1676, but wanted to start with something small. This is mostly just to avoid people needing to use older versions of node when developing in this repo (security, etc.) |
|
Thanks for the PR, @robcresswell! 🙌 @tombeckenham will take a look. Automated pre-review checks
Automated triage — a human review follows. |
|
This comment is automated by a Grok agent. It is not a maintainer review. Verdict: none. The security check blocked this review. Security
A maintainer must review this pull request by hand. |
|
View your CI Pipeline Execution ↗ for commit 38ee2f6
☁️ Nx Cloud last updated this comment at |
@tanstack/ai
@tanstack/ai-acp
@tanstack/ai-angular
@tanstack/ai-anthropic
@tanstack/ai-bedrock
@tanstack/ai-byteplus
@tanstack/ai-claude-code
@tanstack/ai-client
@tanstack/ai-cloudflare
@tanstack/ai-code-mode
@tanstack/ai-code-mode-snippets
@tanstack/ai-codex
@tanstack/ai-cohere
@tanstack/ai-compaction
@tanstack/ai-computer-local
@tanstack/ai-computer-playwright
@tanstack/ai-computer-sandbox
@tanstack/ai-computer-use
@tanstack/ai-devtools-core
@tanstack/ai-durable-stream
@tanstack/ai-elevenlabs
@tanstack/ai-event-client
@tanstack/ai-fal
@tanstack/ai-gemini
@tanstack/ai-grok
@tanstack/ai-grok-build
@tanstack/ai-groq
@tanstack/ai-harness
@tanstack/ai-harness-cli
@tanstack/ai-isolate-cloudflare
@tanstack/ai-isolate-daytona
@tanstack/ai-isolate-e2b
@tanstack/ai-isolate-node
@tanstack/ai-isolate-quickjs
@tanstack/ai-isolate-quickjs-bun
@tanstack/ai-llmgateway
@tanstack/ai-lovable
@tanstack/ai-mcp
@tanstack/ai-memory
@tanstack/ai-mistral
@tanstack/ai-neon
@tanstack/ai-octane
@tanstack/ai-ollama
@tanstack/ai-ollaya
@tanstack/ai-openai
@tanstack/ai-opencode
@tanstack/ai-openrouter
@tanstack/ai-perplexity
@tanstack/ai-persistence
@tanstack/ai-preact
@tanstack/ai-react
@tanstack/ai-reactor
@tanstack/ai-remix
@tanstack/ai-sandbox
@tanstack/ai-sandbox-blaxel
@tanstack/ai-sandbox-boxd
@tanstack/ai-sandbox-cloudflare
@tanstack/ai-sandbox-daytona
@tanstack/ai-sandbox-docker
@tanstack/ai-sandbox-e2b
@tanstack/ai-sandbox-local-process
@tanstack/ai-sandbox-railway
@tanstack/ai-sandbox-sprites
@tanstack/ai-sandbox-upstash-box
@tanstack/ai-sandbox-vercel
@tanstack/ai-skills
@tanstack/ai-solid
@tanstack/ai-svelte
@tanstack/ai-typesafe
@tanstack/ai-utils
@tanstack/ai-vercel-gateway
@tanstack/ai-vertex
@tanstack/ai-vue
@tanstack/ai-worldlabs
@tanstack/openai-base
@tanstack/preact-ai-devtools
@tanstack/react-ai-devtools
@tanstack/solid-ai-devtools
@tanstack/svelte-ai-devtools
commit: |
tombeckenham
left a comment
There was a problem hiding this comment.
Thanks @robcresswell! Checked that CI picks up the new pin from .nvmrc via the shared setup action, and that 24.22.1 is a Node 24 LTS security release. I pushed a small follow-up so the docs point at .nvmrc instead of repeating the version.
The pinned Node version goes from 24.8.0 to 24.22.1, the newest Node 24 LTS release. CI reads
.nvmrcthroughactions/setup-node, so CI moves to 24.22.1 as well. This also picks up the 5 Node 24 security releases since 24.8.0.🎯 Changes
.nvmrc: 24.8.0 → 24.22.1.CONTRIBUTING.md,CLAUDE.md,examples/ts-code-mode-web/README.md: these now say "the Node 24 version in.nvmrc" instead of a version number. Two of them still said 24.8.0. Now the next bump only has to change.nvmrc.No docs change: the library API did not change. No changeset: no published package changed.
✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.docs/for this change, or this change is not user-facing.pnpm changeset), or this PR does not change a published package.🚀 Release Impact
Testing
Commands run.
git grep -n '24\.8\.0' -- ':!pnpm-lock.yaml'finds nothing outside changelogs and SVG files. No test suites were run locally. CI is the check for this change.Manual test.
v24.22.1.nvm install && node -v. Expectv24.22.1.pnpm install && pnpm nx show projects. Expect a list of projects and notsModule.readConfigFileerror.How this PR makes testing easy. It adds no tests. The CI setup step is the check.
Risk / rollback
Low. This is a patch bump inside the Node 24 LTS line. If CI breaks, revert this PR.
Summary by CodeRabbit