Skip to content

fix: correct CockroachDB supportsSchemaEditing test, drop unused loggers #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datlechin merged 1 commit into from
May 14, 2026
Merged

fix: correct CockroachDB supportsSchemaEditing test, drop unused loggers #1263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions Plugins/PostgreSQLDriverPlugin/CockroachPluginDriver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,11 @@
//

import Foundation
import os
import TableProPluginKit

final class CockroachPluginDriver: LibPQBackedDriver, @unchecked Sendable {
let core: LibPQDriverCore

private static let logger = Logger(subsystem: "com.TablePro.PostgreSQLDriver", category: "CockroachPluginDriver")

private var cachedServerVersion: String?

var capabilities: PluginCapabilities {
Expand Down
3 changes: 0 additions & 3 deletions Plugins/PostgreSQLDriverPlugin/LibPQDriverCore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,9 @@
//

import Foundation
import os
import TableProPluginKit

final class LibPQDriverCore: @unchecked Sendable {
private static let logger = Logger(subsystem: "com.TablePro.PostgreSQLDriver", category: "LibPQDriverCore")

private let config: DriverConnectionConfig
private var libpqConnection: LibPQPluginConnection?

Expand Down
4 changes: 2 additions & 2 deletions TableProTests/Models/DatabaseTypeCockroachDBTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ struct DatabaseTypeCockroachDBTests {
#expect(DatabaseType.cockroachdb.supportsForeignKeys == true)
}

@Test("supportsSchemaEditing is true")
@Test("supportsSchemaEditing is false (no driver-side DDL generators)")
func supportsSchemaEditing() {
#expect(DatabaseType.cockroachdb.supportsSchemaEditing == true)
#expect(DatabaseType.cockroachdb.supportsSchemaEditing == false)
}

@Test("iconName is cockroachdb-icon")
Expand Down
Loading