fix: correct CockroachDB supportsSchemaEditing test, drop unused loggers#1263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1262 (CockroachDB support). PR #1262 merged before this review-feedback commit could land, so
maincurrently carries two issues this PR fixes:DatabaseTypeCockroachDBTests.supportsSchemaEditing()asserts== true, butDatabaseType.cockroachdb.supportsSchemaEditingisfalse(CockroachDB ships with no driver-side DDL generators, matching Redshift). The assertion is corrected to== false.Loggerinstances inLibPQDriverCoreandCockroachPluginDriver, plus their now-unusedimport os.Tests
swiftlint --strictclean. CockroachDB test suites pass, includingsupportsSchemaEditing().