Repository navigation
Re-verify the wire contract at Grappa v1.5.12 and refresh the baseline - #241
Merged
Merged
Conversation
Refs the Grappa v1.5.12 realignment: protocol 37 and the record shapes were re-read at the release tag, docs and the protocol comment now point at it, and the own-nick window counts, self-KICK rejoin and wide-row notes are written down with the reasons for leaving them as they are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #239
Branch:
docs-issue-239Re-read the wire contract at Grappa
v1.5.12(commitc26c77bc, the first release speaking protocol 37) and refreshed the baseline in the docs.What I checked at the tag
@protocol_version 37,@min_protocol_version 1inlib/grappa/protocol.ex.dm_withoptional, nodm_conversation_id.query_windows_listentry:network_id,target_nick,opened_at.mentions_bundlerows:idanddm_withoptional.docs/CLIENT_PROTOCOL.mddiff since189aaf2c: everything that touches Cordiale (v31 ignore pairs, v32 away nick suffix, v33 network delete +message_count, v34-v37 DM changes) is already in the code.GET /api/configon the author's server answersversion1.5.12, protocol 37.What changed
docs/protocol-notes.md,docs/feature-matrix.md: new baseline (v1.5.12), the "not verified against a real v35/v36/v37 server" notes now say what was checked at the source and what is still untested in a live session.crates/cordiale-core/src/protocol.rs: comment only.Decisions on the leftovers (no code change)
(network, current own nick)and ignores the payload'schannel; the server setschannelto the topic segment. Cordiale rejoins the own-nick listener with the new nick onown_nick_changed, so the comparison holds. Only a push on the old topic before the rejoin is dropped (Cicchetto would route it to the new nick), which is transient and harmless. The count doesn't classify rows, sodm_withisn't needed.kicked/joined/join_failedas window states with a faded sidebar row, including from a reconnect snapshot.StyledTextin aListViewwith no explicit clip. No local build here, so a long line without spaces still needs an eyeball check on desktop; noted in the feature matrix.Live flows (DM routing after a rename, mentions bundle, admin network delete with
message_count) stay for a hand test against a real v1.5.12 session.