You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fractional authored controls now retain their leading glyph column and use physical scissor bounds across Java GUI scales. Continue the full movement, inventory, native screens, camera, rendering, and skin-parity goal in this PR.
The renderer intersects floating native bounds before truncating the scaled origin and extent. Each draw retains physical clip metadata, while Java overlap checks use conservative GUI bounds. Batching distinguishes physical clips even when their coarse GUI rectangles match. Forms, HUD scenes, nested inputs, and authored containers share this path. The changes remain folded into the owning shared-renderer and container patches.
Validation uses official Bedrock 1.26.60.5 with BDS 1.26.60.6, protocol 2225. A native fixture covers 42 static labels. All 36 reference and parent-clipping masks match the installed add-on at 1280 × 720 and native UI scale 2, at Java GUI scales 1, 2, 3, and return to 1. These controls cover fractional origins, all four edges, and nested parents. The complete 180-second replay preserves the recorded scene payload hash and verifies the installed JAR. All replay-owned process identities are terminal.
The full dependency build passes. The add-on suite reports 1,445 tests, no failures, and 153 optional skips. New regressions compare native glyph masks and reject batching distinct physical clips with identical GUI bounds. Patch preparation and diff checks pass.
The six short-height labels still differ: native omits the text, while Java clips it. That height-admission rule, backgrounds, action appearance, complete authored-screen and container GPU parity, and all broader compatibility scope remain open. Early images covered by tutorial or startup chat warnings are excluded from parity evidence. This work does not establish a fresh public-server result.
Summary by CodeRabbit
New Features
Added native-rendered Bedrock menus for common containers, player inventory, and workbench screens, with Java inventory interactions retained.
Added configurable native inventory screens, along with native UI scaling, scrolling, search, preferences, animations, and item and portrait rendering.
Added support for native HUD overlays and interactive controls, including keyboard and pointer input.
Bug Fixes
Improved clipping and layout accuracy for fractional positions and nested panels.
Unsupported or incomplete native presentations fall back to the original screen.
Record the named controls required by the verified scrollbar layout path. Keep omitted-name layout and painting behavior open for a matched native comparison in the next maintenance PR.
The shared native UI renderer now preserves fractional clip bounds through physical-pixel scissoring, extraction, and batching. Authored container screens use the same scissor path. Regression fixtures and validation notes cover fractional origins, edges, nested clips, and matching coarse bounds.
Native clips intersect floating-point bounds before truncation and retain physical clip metadata for batching and rendering. Regression coverage and validation notes describe fractional origins, edges, nested clips, and distinct physical clips that share coarse GUI bounds.
Apply clips across native UI rendering patches/viafabricplus-bedrock/upstreamable/0029-share-native-ui-scene-rendering.patch, patches/viafabricplus-bedrock/upstreamable/0029-present-authored-native-containers.patch, patches/viafabricplus-bedrock/upstreamable/0029-present-authored-native-containers.pr.md
Native UI graphics, scene rendering, HUD overlays, and authored container screens use the shared physical-pixel scissor path. Mixins carry clip metadata and apply clamped bounds during GUI rendering. Documentation records fractional-bound preservation and the scope of glyph comparisons.
StackAnvil/patches#27: Updates the same shared UI patch and documents scrollbar layout behavior.
StackAnvil/patches#21: Contains an earlier version of the shared native UI scene rendering patch.
StackAnvil/patches#26: Includes the shared UI renderer and authored-container presentation patches.
Merge Risk: Minimal · up to 3fa33
Native UI and containers now share physical-pixel clipping. No concrete merge-blocking issue was established.
Pre-merge checks: 3 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Title check
The title "Continue compatibility improvements" is vague and generic. It does not name the main change. The PR covers many areas, including native Bedrock UI scene rendering, container presentation, s…
Replace the title with a specific summary of the primary change. For example, name the main feature or fix, such as native container presentation, shared native UI scene rendering, or physical-pixel scissor clipping for Bedrock GUI scales. …
Passed checks: 3 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title "Continue compatibility improvements" is vague and generic. It does not name the main change. The PR covers many areas, including native Bedrock UI scene rendering, container presentation, scissor and clipping fixes, and documentation of verified scrollbar and glyph behavior. The title uses no specific term that tells a reviewer what changed. The changeset does not contradict the title, so it is not off-topic.
Resolution
Replace the title with a specific summary of the primary change. For example, name the main feature or fix, such as native container presentation, shared native UI scene rendering, or physical-pixel scissor clipping for Bedrock GUI scales. Keep it to one short sentence.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Replace the unconfirmed glyph-edge lead with native 1.26.60.5 and installed Java controls. Preserve physical scissor precision and complete authored-screen parity as unresolved work.
Retain floating native parent intersections until origin and extent conversion at the framebuffer boundary. Carry physical clip data with each draw and use it for batching while keeping conservative GUI bounds for overlap checks.
Route authored forms, HUD scenes, and containers through the shared path. Native reference masks cover all four clip edges and nested parents; short-label height admission and complete screen appearance remain open.
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Use an upstream-neutral name for the scissor accessors.
This upstreamable patch adds stackanvil$scissor to the Bedrock add-on API. Rename both accessors and their mixin and call sites to bedrock$scissor, consistent with the existing Bedrock bridge naming. As per path instructions, “Review the patch as upstream source code. Check whether branding or downstream-only changes leaked into a feature patch, and whether later patches can still replay.”
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Fractional authored controls now retain their leading glyph column and use physical scissor bounds across Java GUI scales. Continue the full movement, inventory, native screens, camera, rendering, and skin-parity goal in this PR.
The renderer intersects floating native bounds before truncating the scaled origin and extent. Each draw retains physical clip metadata, while Java overlap checks use conservative GUI bounds. Batching distinguishes physical clips even when their coarse GUI rectangles match. Forms, HUD scenes, nested inputs, and authored containers share this path. The changes remain folded into the owning shared-renderer and container patches.
Validation uses official Bedrock 1.26.60.5 with BDS 1.26.60.6, protocol 2225. A native fixture covers 42 static labels. All 36 reference and parent-clipping masks match the installed add-on at 1280 × 720 and native UI scale 2, at Java GUI scales 1, 2, 3, and return to 1. These controls cover fractional origins, all four edges, and nested parents. The complete 180-second replay preserves the recorded scene payload hash and verifies the installed JAR. All replay-owned process identities are terminal.
The full dependency build passes. The add-on suite reports 1,445 tests, no failures, and 153 optional skips. New regressions compare native glyph masks and reject batching distinct physical clips with identical GUI bounds. Patch preparation and diff checks pass.
The six short-height labels still differ: native omits the text, while Java clips it. That height-admission rule, backgrounds, action appearance, complete authored-screen and container GPU parity, and all broader compatibility scope remain open. Early images covered by tutorial or startup chat warnings are excluded from parity evidence. This work does not establish a fresh public-server result.
Summary by CodeRabbit