You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Native UI backgrounds could remain transparent when a nine-slice interior stretched a single texture point. Bedrock 1.26.60.5 uses this layout for its opaque 2×2 Black texture. The Java draw path discarded these regions because their UV endpoints coincide.
The owning shared-renderer patch now submits nonempty destinations with constant UV coordinates. Empty destination and non-finite geometry checks remain in place. The draw regression fails before the correction and also checks that a zero-width destination emits no graphics calls.
The rebuilt installed add-on matches all 266,072 sampled native background pixels at 1280 × 720 and native UI scale 2. Java GUI scales 1, 2, 3, and return to 1 retain the match and all 63 selected bitmap glyph masks. Text bounds and the action button are excluded from the background sample. The previous installed control had 265,694 non-black pixels in that same background sample.
The complete 180-second replay preserves the recorded scene payload and verifies the installed add-on bytes. All recorded Java process identities are terminal.
The full dependency build passes: CubeConverter 21 tests, ViaBedrock 2,240 tests, and the add-on 1,451 tests, with no failures. Core and add-on retain 176 and 153 optional skips.
The TrueType investigation now executes the original Bedrock 1.26.60.5 initializer, glyph lookup, outline, rectangle, raster, and filter instructions. Native cache pixels and packed metrics match the installed LWJGL 3.4.3 STB rasterizer in all 36 CPU controls: six glyphs at three heights for MinecraftTen and an additional curved-outline font. Native rasterization uses fractional scaling and 2×2 oversampling. The fixture supplies atlas placement and external allocation, memory, and rounding interfaces; it does not execute cache I/O, GPU upload, shaders, or full native screens. A production provider, bounded font validation, resource lifecycle, and GPU comparisons remain required. Production font behavior is unchanged.
Other background layouts, TrueType glyph appearance, narrow-label overflow with a glyph smaller than the marker, action appearance, and complete screen parity remain open. The full movement, inventory actions, native screens, camera, rendering integration, and skin-parity goals remain active. No fresh public-server result is included.
Summary by CodeRabbit
New Features
Added native Bedrock UI scene support, including layouts, images, text, animations, input, focus, scrolling, and viewport handling.
Added native HUD overlays, actor portraits, bitmap fonts, multiline text boxes, and support for JPEG and bounded remote images.
Bug Fixes
Nine-slice images now render when their destination has area, including when sampling a single texture point. Empty destinations remain skipped.
Record the version-matched outline scale and the installed Java provider rounding behavior. Keep the remaining raster work explicit so an oversampling adjustment cannot be mistaken for native pixel parity.
No actionable comments were generated in the recent review.
Walkthrough
The patch updates nine-slice image submission so nonempty regions with coincident UV endpoints are drawn, and adds regression coverage and rendering validation notes. Separate validation notes report native and Java font-scaling comparisons and their fixture limits.
Changes: Native UI scene rendering
Layer / File(s)
Summary
Nine-slice submission and regression coverage patches/viafabricplus-bedrock/upstreamable/0029-share-native-ui-scene-rendering.patch, patches/viafabricplus-bedrock/upstreamable/0029-share-native-ui-scene-rendering.pr.md
Image submission no longer rejects a region only because its U or V endpoints are equal. Zero-width and zero-height destinations remain skipped. A regression test checks both cases. Validation notes report sampled background parity and retain open items for other background layouts, action appearance, and complete column placement.
Font scaling validation
Layer / File(s)
Summary
Font raster comparison findings patches/viabedrock/upstreamable/0095-share-native-ui-programs-and-resources.pr.md
The validation notes compare native glyph-cache scale with Java provider-size scaling. They report matching pixels and packed metrics across 36 CPU cache controls and state the fixture limits and remaining validation needs.
StackAnvil/patches#20: Changes the same shared UI renderer and resource patches covered by this pull request.
StackAnvil/patches#28: Changes shared UI renderer paths, including clipping and glyph rendering.
StackAnvil/patches#29: Changes the shared UI renderer and bitmap-font layout code, which overlap with this pull request’s renderer and font validation areas.
Merge Risk: Minimal · up to 5171b
No concrete merge-blocking defect is established by the reviewed changes.
Pre-merge checks: 4 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Title check
The title "Continue compatibility improvements" is vague and generic. It does not name the main change, which is a shared-renderer correction for native UI nine-slice backgrounds (constant UV coordina…
Replace the title with a specific summary of the primary change. For example: "Fix nine-slice UI background UV coordinates for native UI rendering" or a similar title that names the nine-slice background correction in the shared renderer.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
Full details: Title check
Explanation
The title "Continue compatibility improvements" is vague and generic. It does not name the main change, which is a shared-renderer correction for native UI nine-slice backgrounds (constant UV coordinates for nonempty destinations with coincident UV endpoints), along with related native UI rendering and font work. The phrase "compatibility improvements" could describe any change, so a teammate scanning history cannot identify the primary change from it.
Resolution
Replace the title with a specific summary of the primary change. For example: "Fix nine-slice UI background UV coordinates for native UI rendering" or a similar title that names the nine-slice background correction in the shared renderer.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Preserve nonempty native UI regions whose UV endpoints coincide. The version-matched 2x2 Black texture uses this layout, and dropping its center exposed the world through the background.
Fold the correction and regression into the owning renderer patch. The full build passes, and an installed 180-second replay retains the scene payload while matching the sampled native background and 63 bitmap glyph masks across GUI scales.
Distinguish native base metrics from the doubled raster scale. Record 36 original-instruction cache controls that match the installed STB rasterizer, along with the fixture boundaries and the provider and GPU work still required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native UI backgrounds could remain transparent when a nine-slice interior stretched a single texture point. Bedrock 1.26.60.5 uses this layout for its opaque 2×2 Black texture. The Java draw path discarded these regions because their UV endpoints coincide.
The owning shared-renderer patch now submits nonempty destinations with constant UV coordinates. Empty destination and non-finite geometry checks remain in place. The draw regression fails before the correction and also checks that a zero-width destination emits no graphics calls.
The rebuilt installed add-on matches all 266,072 sampled native background pixels at 1280 × 720 and native UI scale 2. Java GUI scales 1, 2, 3, and return to 1 retain the match and all 63 selected bitmap glyph masks. Text bounds and the action button are excluded from the background sample. The previous installed control had 265,694 non-black pixels in that same background sample.
The complete 180-second replay preserves the recorded scene payload and verifies the installed add-on bytes. All recorded Java process identities are terminal.
The full dependency build passes: CubeConverter 21 tests, ViaBedrock 2,240 tests, and the add-on 1,451 tests, with no failures. Core and add-on retain 176 and 153 optional skips.
The TrueType investigation now executes the original Bedrock 1.26.60.5 initializer, glyph lookup, outline, rectangle, raster, and filter instructions. Native cache pixels and packed metrics match the installed LWJGL 3.4.3 STB rasterizer in all 36 CPU controls: six glyphs at three heights for MinecraftTen and an additional curved-outline font. Native rasterization uses fractional scaling and 2×2 oversampling. The fixture supplies atlas placement and external allocation, memory, and rounding interfaces; it does not execute cache I/O, GPU upload, shaders, or full native screens. A production provider, bounded font validation, resource lifecycle, and GPU comparisons remain required. Production font behavior is unchanged.
Other background layouts, TrueType glyph appearance, narrow-label overflow with a glyph smaller than the marker, action appearance, and complete screen parity remain open. The full movement, inventory actions, native screens, camera, rendering integration, and skin-parity goals remain active. No fresh public-server result is included.
Summary by CodeRabbit